[dev-v2.9] rancher-vsphere-csi 104.1.0+up3.3.1-rancher7 add #4913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the chart to this upstream commit:
It will also incorporate other changes that were added to the chart in between, that are already present in the v2.10 branch.
Issue: rancher/rancher#48054
Engineeering testing
For testing that this latest bump had an effect, I installed the csi chart in the local cluster, even though it wasn't a vsphere cluster, because it was still possible to verify that arguments could be passed. To do this, I customized the following values before installing the chart (directly in the value yaml view):
Note that these values have to be configured individually, and the other ones left as they are. The point is to pass additional args to every container. It's also necessary to enable the csi resizer and block volume snapshots so two of the containers run.
After this, I checked the logs every container for one controller deployment and the single node deployment (a total of 10 containers). Those that were passed
--logging-format=json
had json output in their logs, and those that were passed-version/--version
printed their version before exiting. Most containers failed because this was not run in a vsphere environment, but it was sufficient to verify that the arguments were being passed correctly.QA considerations
Be aware that the engineer tests above cover the changes from the last upstream commit of this bump, but on this branch the bump covered a few commits, so those might also need verification.
Test suggestions: