Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/UI - Bump to Rancher 2.10 #85

Merged
merged 3 commits into from
Dec 5, 2024
Merged

CI/UI - Bump to Rancher 2.10 #85

merged 3 commits into from
Dec 5, 2024

Conversation

cpinjani
Copy link
Collaborator

@cpinjani cpinjani commented Dec 3, 2024

What does this PR do?

With respect to turtles latest release v0.14.0, bump & fix code to work with rancher 2.10
Changes are inspired from rancher-sandbox/rancher-ecp-qa#18

Checklist:

Signed-off-by: Chandan Pinjani <chandan.pinjani@suse.com>
@cpinjani cpinjani requested a review from thehejik December 3, 2024 15:53
@cpinjani cpinjani self-assigned this Dec 3, 2024
Copy link
Collaborator

@thehejik thehejik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please bump also ele-testhelpers module for the head support?

Other than that LGTM.

Signed-off-by: Chandan Pinjani <chandan.pinjani@suse.com>
@cpinjani
Copy link
Collaborator Author

cpinjani commented Dec 3, 2024

Could you please bump also ele-testhelpers module for the head support?

Other than that LGTM.

Good suggestion, Done.
https://github.com/rancher/rancher-turtles-e2e/actions/runs/12143720806

@cpinjani cpinjani changed the title CI/UI - Bump to Rancher 2.10 WIP: CI/UI - Bump to Rancher 2.10 Dec 4, 2024
@cpinjani cpinjani force-pushed the bump-2.10 branch 2 times, most recently from bde345e to 827cc41 Compare December 4, 2024 15:39
Signed-off-by: Chandan Pinjani <chandan.pinjani@suse.com>
@cpinjani
Copy link
Collaborator Author

cpinjani commented Dec 5, 2024

@cpinjani cpinjani changed the title WIP: CI/UI - Bump to Rancher 2.10 CI/UI - Bump to Rancher 2.10 Dec 5, 2024
Copy link
Collaborator

@thehejik thehejik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the go deps bump, the fix looks good as well.

@cpinjani cpinjani merged commit d4561c6 into main Dec 5, 2024
6 checks passed
@cpinjani cpinjani deleted the bump-2.10 branch December 5, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants