Setting for selecting linux-terminal windows by WM_NAME (window title)
#164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdbrendel
changed the title
linux-terminal windows by WM_NAME (window title)
randy3k
reviewed
Feb 3, 2022
randy3k
reviewed
Feb 3, 2022
randy3k
reviewed
Feb 3, 2022
…eferences of `window_name` setting to `linux_window_name` (accidentally omitted in prior commit)
|
Thanks for reviewing so quickly @randy3k! I agree with all your feedback and I've implemented your suggestions in the latest commits. |
…le for linux-terminal)
randy3k
reviewed
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I proposed in #163, this pull request adds an optional setting
window_namethat alters the behavior of thelinux-terminalprog setting. If set,xdotoolwill attempt to find a window with aWM_NAMEthat matches thewindow_namepattern. If unsuccessful, it will fall back to the default behavior (i.e., just send code to the latest window whoseWM_CLASSmatches the value oflinux_terminal). This pull request also contains a proposed subsection in the readme describing the use-case ofwindow_nameand giving an example configuration.The anticipated user of this setting is someone who simultaneously uses multiple windows that contain multiple REPLs--for example, a researcher or analyst working on a project with a mixed codebase whose workflow consists of running Python code before running some R code to analyze the results. This pull should be particularly useful for users who configure their workspace[s] with saved layouts (in which assigning immutable names to windows is very common). Prior to this pull request, the workaround that I personally used to emulate this behavior was to run different REPLs in different terminal emulators (radian in Terminator, ipython in kitty, etc.).
This is obviously my first pull request for SendCode, so sorry for any silly mistakes or assumptions!