-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SentinelOne validation checks #3031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorski-r7
approved these changes
Jan 7, 2025
joneill-r7
reviewed
Jan 7, 2025
cmcnally-r7
force-pushed
the
soar_18184_sentinelone_validation_checks
branch
from
January 8, 2025 10:12
08d92ee
to
e8daee1
Compare
rmurray-r7
approved these changes
Jan 8, 2025
igorski-r7
approved these changes
Jan 8, 2025
joneill-r7
approved these changes
Jan 8, 2025
cmcnally-r7
added a commit
that referenced
this pull request
Jan 8, 2025
* Fix issue with input validation * Black formatting * Check for whitespace and change version back to 11.1.3 * Fix help.md
cmcnally-r7
added a commit
that referenced
this pull request
Jan 8, 2025
* Fix issue with input validation * Black formatting * Check for whitespace and change version back to 11.1.3 * Fix help.md
cmcnally-r7
added a commit
that referenced
this pull request
Jan 8, 2025
* Fix issue with input validation * Black formatting * Check for whitespace and change version back to 11.1.3 * Fix help.md
cmcnally-r7
added a commit
that referenced
this pull request
Jan 8, 2025
* [SOAR-18473] SentinelOne - fedRAMP, SDK bump and vuln (#3010) * sentinelone - sdk and vuln * fix schema * SentinelOne validation checks (#3031) * Fix issue with input validation * Black formatting * Check for whitespace and change version back to 11.1.3 * Fix help.md --------- Co-authored-by: Conor <93926445+cmcnally-r7@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Describe the proposed changes:
PR Requirements
Developers, verify you have completed the following items by checking them off:
Testing
Unit Tests
Review our documentation on generating and writing plugin unit tests
In-Product Tests
If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:
Style
Review the style guide
USER nobody
in theDockerfile
when possiblerapid7/insightconnect-python-3-38-slim-plugin:{sdk-version-num}
andrapid7/insightconnect-python-3-38-plugin:{sdk-version-num}
insight-plugin validate
which callsicon_validate
to linthelp.md
Functional Checklist
tests/
directory created withinsight-plugin samples
tests/$action_bad.json
insight-plugin run -T tests/example.json --debug --jq
insight-plugin run -T all --debug --jq
(use PR format at end)insight-plugin run -R tests/example.json --debug --jq
insight-plugin run --debug --jq
(use PR format at end)Assessment
You must validate your work to reviewers:
insight-plugin validate
and make sure everything passesinsight-plugin run -A
. For single action validation:insight-plugin run tests/{file}.json -A
insight-plugin ... | pbcopy
) and paste the output in a new post on this PR