-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twilio - 27416 - Updated dependencies | Updated SDK to the latest version #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorski-r7
requested review from
cmcnally-r7,
ablakley-r7,
dlaverty-r7,
joneill-r7,
ekelly-r7,
rbowden-r7,
rmurray-r7 and
lcwiklinski-r7
January 7, 2025 15:43
rmurray-r7
reviewed
Jan 7, 2025
rmurray-r7
reviewed
Jan 7, 2025
rmurray-r7
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few suggestions so data doesn't get lost during refresh. The description will not work when running refresh until my recent PR get's merged as it fixes an issue with \n
igorski-r7
force-pushed
the
Twilio_Refactor
branch
from
January 7, 2025 16:40
dfb638e
to
e0afde0
Compare
igorski-r7
force-pushed
the
Twilio_Refactor
branch
from
January 7, 2025 16:55
e0afde0
to
3f63736
Compare
joneill-r7
approved these changes
Jan 7, 2025
ablakley-r7
approved these changes
Jan 8, 2025
igorski-r7
force-pushed
the
Twilio_Refactor
branch
7 times, most recently
from
January 10, 2025 10:08
a463b44
to
1644bf8
Compare
igorski-r7
force-pushed
the
Twilio_Refactor
branch
from
January 10, 2025 15:35
1644bf8
to
5e2464c
Compare
igorski-r7
force-pushed
the
Twilio_Refactor
branch
from
January 13, 2025 12:24
5e2464c
to
acf6146
Compare
igorski-r7
added a commit
that referenced
this pull request
Jan 13, 2025
igorski-r7
added a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Describe the proposed changes:
twilio
API client to the latest version6.2.2
)PR Requirements
Developers, verify you have completed the following items by checking them off:
Testing
Unit Tests
Review our documentation on generating and writing plugin unit tests
In-Product Tests
If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:
Style
Review the style guide
USER nobody
in theDockerfile
when possiblerapid7/insightconnect-python-3-38-slim-plugin:{sdk-version-num}
andrapid7/insightconnect-python-3-38-plugin:{sdk-version-num}
insight-plugin validate
which callsicon_validate
to linthelp.md
Functional Checklist
tests/
directory created withinsight-plugin samples
tests/$action_bad.json
insight-plugin run -T tests/example.json --debug --jq
insight-plugin run -T all --debug --jq
(use PR format at end)insight-plugin run -R tests/example.json --debug --jq
insight-plugin run --debug --jq
(use PR format at end)Assessment
You must validate your work to reviewers:
insight-plugin validate
and make sure everything passesinsight-plugin run -A
. For single action validation:insight-plugin run tests/{file}.json -A
insight-plugin ... | pbcopy
) and paste the output in a new post on this PR