[SOAR-18528] Whois - SDK Bump and dependency resolution #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmurray-r7
force-pushed
the
whois_repo
branch
from
481fabe to
62a5bd8
Compare
rmurray-r7
requested review from
cmcnally-r7,
ablakley-r7,
igorski-r7,
dlaverty-r7 and
ekelly-r7
igorski-r7
approved these changes
Jan 16, 2025
ablakley-r7
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
When using buildpacks to build the image, when running there were several syntax errors linked to the whois dependency. Updates were made to the repo to resolve these syntax errors and so the dependency needs updated to reflect this.
Describe the proposed changes:
This will get merged with the other PR's:
Testing
When using a different dependency there were errors when running the domain action. When tested against the new dependency there is no syntax errors and the domain action works:
Validator is expected to fail due to CloudReady