Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply east const using clang-format. Fix header issues reported by clang-tidy #594

Draft
wants to merge 3 commits into
base: branch-25.04
Choose a base branch
from

Conversation

kingcrimsontianyu
Copy link
Contributor

@kingcrimsontianyu kingcrimsontianyu commented Jan 23, 2025

This small PR applies east const style using clang-format. This makes KvikIO consistent with cuDF in coding style. The following parameters were applied to .clang-format for auto-reformatting. The file .clang-format itself is not updated in this PR.

QualifierAlignment: Custom
QualifierOrder: [inline, static, type, const, volatile]

In addition, this PR fixes minor "missing header" issues reported by clang-tidy.

Copy link

copy-pr-bot bot commented Jan 23, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@kingcrimsontianyu kingcrimsontianyu self-assigned this Jan 23, 2025
@kingcrimsontianyu kingcrimsontianyu added improvement Improves an existing functionality non-breaking Introduces a non-breaking change c++ Affects the C++ API of KvikIO labels Jan 23, 2025
@kingcrimsontianyu
Copy link
Contributor Author

/ok to test

@kingcrimsontianyu kingcrimsontianyu changed the base branch from branch-25.02 to branch-25.04 January 24, 2025 03:34
@kingcrimsontianyu kingcrimsontianyu marked this pull request as ready for review January 24, 2025 03:34
@kingcrimsontianyu kingcrimsontianyu requested a review from a team as a code owner January 24, 2025 03:34
@kingcrimsontianyu kingcrimsontianyu marked this pull request as draft January 24, 2025 03:38
@kingcrimsontianyu
Copy link
Contributor Author

Converted to draft until CI/container issue is fixed.

@kingcrimsontianyu
Copy link
Contributor Author

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Affects the C++ API of KvikIO improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant