-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example of Slice Tests #189
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new module, Class diagram for the new test-slice-tests module structureclassDiagram
class User {
+String id
+String name
+String email
}
class UserRepository {
<<interface>>
+findById(String id)
+save(User user)
}
class UserResource {
-UserRepository repository
+getUser(String id)
+createUser(User user)
}
UserResource --> UserRepository : uses
UserRepository --> User : manages
note for UserRepository "Spring Data Repository"
note for UserResource "REST Controller"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rashidi - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR sets up the infrastructure but is missing actual slice test examples (@WebMvcTest, @DataJpaTest, etc.) which are needed to demonstrate the different types of Spring Boot slice tests. Please add these test examples to fulfill the module's purpose.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
test-slice-tests/src/test/java/zin/rashidi/boot/test/slices/TestSliceTestsApplicationTests.java
Outdated
Show resolved
Hide resolved
...tests-rest/src/main/java/zin/rashidi/boot/test/slices/security/WebSecurityConfiguration.java
Fixed
Show fixed
Hide fixed
Quality Gate passedIssues Measures |
Summary by Sourcery
Add a module to demonstrate Slice Tests using Spring Boot Test Slice.
New Features:
Tests: