Merge pull request #294 from ray-di/pure

Enhance code quality with Psalm annotations

src/di/Argument.php

@@ -171,6 +171,9 @@ private function setDefaultValue(ReflectionParameter $parameter): void
         }
     }
 
+    /**
+     * @psalm-pure
+     */
     private function getType(ReflectionParameter $parameter): string
     {
         $type = $parameter->getType();

src/di/Di/Inject.php

@@ -13,6 +13,7 @@
  * @Annotation
  * @Target("METHOD")
  * @NamedArgumentConstructor
+ * @psalm-immutable
  */
 #[Attribute(Attribute::TARGET_METHOD | Attribute::TARGET_PARAMETER)]
 final class Inject implements InjectInterface
@@ -22,7 +23,7 @@ final class Inject implements InjectInterface
      *
      * @var bool
      */
-    public $optional = false;
+    public $optional;
 
     /**
      * @SuppressWarnings(PHPMD.BooleanArgumentFlag) // @phpstan-ignore-line

src/di/Di/Named.php

@@ -13,12 +13,13 @@
  * @Annotation
  * @Target("METHOD")
  * @NamedArgumentConstructor
+ * @psalm-immutable
  */
 #[Attribute(Attribute::TARGET_PARAMETER | Attribute::TARGET_METHOD | Attribute::TARGET_PROPERTY)]
 final class Named
 {
     /** @var string */
-    public $value = '';
+    public $value;
 
     public function __construct(string $value)
     {

src/di/Di/Set.php

@@ -12,6 +12,7 @@
  * @Target({"METHOD","PROPERTY"})
  * @NamedArgumentConstructor()
  * @template T of object
+ * @psalm-immutable
  */
 #[Attribute(Attribute::TARGET_PARAMETER | Attribute::TARGET_PROPERTY)]
 final class Set

src/di/Exception/Unbound.php

@@ -48,6 +48,9 @@ private function buildMessage(self $e, array $msg): string
         return $this->getMainMessage($lastE) . implode('', $msg);
     }
 
+    /**
+     * @psalm-pure
+     */
     private function getMainMessage(self $e): string
     {
         return sprintf(

src/di/MultiBinder.php

@@ -5,7 +5,7 @@
 namespace Ray\Di;
 
 use Ray\Di\MultiBinding\LazyInstance;
-use Ray\Di\MultiBinding\LazyInteterface;
+use Ray\Di\MultiBinding\LazyInterface;
 use Ray\Di\MultiBinding\LazyProvider;
 use Ray\Di\MultiBinding\LazyTo;
 use Ray\Di\MultiBinding\MultiBindings;
@@ -80,7 +80,7 @@ public function toInstance($instance): void
         $this->bind(new LazyInstance($instance), $this->key);
     }
 
-    private function bind(LazyInteterface $lazy, ?string $key): void
+    private function bind(LazyInterface $lazy, ?string $key): void
     {
         $bindings = [];
         if ($this->multiBindings->offsetExists($this->interface)) {

src/di/MultiBinding/LazyInstance.php

@@ -8,8 +8,9 @@
 
 /**
  * @template T of mixed
+ * @psalm-immutable
  */
-final class LazyInstance implements LazyInteterface
+final class LazyInstance implements LazyInterface
 {
     /** @var T */
     private $instance;

src/di/MultiBinding/LazyInteterface.php → src/di/MultiBinding/LazyInterface.php

@@ -6,7 +6,7 @@
 
 use Ray\Di\InjectorInterface;
 
-interface LazyInteterface
+interface LazyInterface
 {
     /**
      * @return mixed

src/di/MultiBinding/LazyProvider.php

@@ -10,7 +10,7 @@
 /**
  * @template T of ProviderInterface
  */
-final class LazyProvider implements LazyInteterface
+final class LazyProvider implements LazyInterface
 {
     /** @var class-string<T> */
     private $class;

src/di/MultiBinding/LazyTo.php

@@ -9,7 +9,7 @@
 /**
  * @template T of object
  */
-final class LazyTo implements LazyInteterface
+final class LazyTo implements LazyInterface
 {
     /** @var class-string<T> */
     private $class;

src/di/MultiBinding/Map.php

@@ -23,14 +23,14 @@
  */
 final class Map implements IteratorAggregate, ArrayAccess, Countable
 {
-    /** @var array<array-key, LazyInteterface> $lazies */
+    /** @var array<array-key, LazyInterface> $lazies */
     private $lazies;
 
     /** @var InjectorInterface */
     private $injector;
 
     /**
-     * @param array<array-key, LazyInteterface> $lazies
+     * @param array<array-key, LazyInterface> $lazies
      */
     public function __construct(array $lazies, InjectorInterface $injector)
     {

src/di/MultiBinding/MultiBindings.php

@@ -9,7 +9,7 @@
 use function array_merge_recursive;
 
 /**
- * @extends ArrayObject<string, non-empty-array<array-key, LazyInteterface>>
+ * @extends ArrayObject<string, non-empty-array<array-key, LazyInterface>>
  */
 final class MultiBindings extends ArrayObject
 {

src/di/Name.php

@@ -141,6 +141,8 @@ private function setName(string $name): void
 
     /**
      * @return array<string, string>
+     *
+     * @psalm-pure
      */
     private function parseName(string $name): array
     {