Add automatic .editorconfig support (2) #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razzmatazz
force-pushed
the
editorconfig-support
branch
from
2f3f6d7 to
395fb9d
Compare
|
hi, are there any plans to complete this PR? |
|
@mxvoloshin I was looking at the specs for Document Formatting Request (https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_formatting) and I am not sure that this approach is correct. In particular, the client is supposed supposed to supply |
|
At the moment I am leaning towards making it configurable, with the default of that where editorconfig will take precedance over FormattingOptions passed in from LSP. |
Now the document is formatted according to the rules of the .editorconfig file, if such a file is present in the solution.
…tings during formatting
razzmatazz
force-pushed
the
editorconfig-support
branch
from
395fb9d to
a039851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate branch from dmitry's #200