-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom theme style improvements and fixes #113
Conversation
… legends (not titles and buttons)
… legends (not titles and buttons)
Hi @gdfreitas I am really sorry polluted this PR a bit - meant to bring it up to date with live before reviewing (I have updated a few things recently) and ended up in merge-conflict purgatory. This all looks great and I am generally happy with it. The story is good to have - if you are happy to add to the RCPCHChart.mdx with some documentation about what you have done and so on would be great. Really useful. |
Hi @eatyourpeas as we discussed, I'm closing this in favor of #117, which is still a work in progress for now. Thank you. |
Changes
Source Issue #111
Fixes
font-style
property being used for settingfont-weight
values1.1 Now it supports both font-style and font-weight properties, defaults were kept.
Adds support for customizing a few properties from existing style objects, as well as new ones introduced in this merge request.
CustomThemeStylesChart
story was added just as a reference, it can be removed before incorporating this pull request, if you feel so. I thought it would be nice to have a dedicated story to show how customizable the chart is apart of existing themes.@eatyourpeas