Domain aggregation #955
Merged
Domain aggregation #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Dec 4, 2024
| """ | ||
| Create an index of domains for each advertisement | ||
|
|
||
| Indexed one per ad/domain per day. |
There was a problem hiding this comment.
I wonder if this should be per flight? That's how the niche targeting is scoped. Per ad will definitely increase the size, but shouldn't be too bad.
There was a problem hiding this comment.
We don't have any aggregations that are currently per flight. All these aggregations are subtly different and that does make factoring common code a challenge.
There was a problem hiding this comment.
Per ad is probably fine to start with, then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.