Enable ETL pipeline if available #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pipeline is from a private repo
ericholscher
approved these changes
Jan 23, 2025
| @@ -20,6 +20,14 @@ trafilatura | |||
| # but we need to make sure lxml.html.clean is installed too | |||
| lxml[html_clean] | |||
|
|
|||
|
|
|||
| ####################################################################### | |||
| # ETL Pipeline | |||
There was a problem hiding this comment.
I wonder about moving these into the ext repo, feels weird to have them here.
There was a problem hiding this comment.
It does feel a bit awkward. However, that module is not installed but rather just added to the path. There aren't requirements installed from that module currently. We could change that.
There was a problem hiding this comment.
I think the plan is to merge as-is with the idea to clean up the installation of the ext repo at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pipeline is from a private repo