-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore an alternative way of explaining states #11512
Conversation
The "remove edit buttons" file was deleted in #11468
Hmmm, actually we talk about privacy levels and document states, and this change obfuscates that a little. |
Yea, it's a bit confusing, but I think this PR is definitely a step in the right direction. "Not hidden" is a bit of an odd state, but useful to explicitly note. I feel like the "How we envision this working" is also weird and something I want to update, and we should probably note a couple different workflows that are enabled, and suggestions for when they are the best option. I can try to take a swing at the "How we envision this working" section if it makes sense in this PR, or should I open another to not mix things up? |
@ericholscher I'm just pushing up some changes to that section, but feel free to revert and propose edits in this PR, or build from it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels way better than what we had before 👍
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement! 💯 . I left a few comments that we can consider.
Some quick noodling on #11508 -- this makes more sense to me, but I'm happy to have another bash.
Is there a canonical link for allocating permissions? Or is that all tied in up SSO?
📚 Documentation previews 📚
docs
): https://docs--11512.org.readthedocs.build/en/11512/dev
): https://dev--11512.org.readthedocs.build/en/11512/