[C] add a call to init the new fields in the logbuffer metadata #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+126
to
+132
| AERON_SET_ERR( | ||
| EINVAL, | ||
| "%s=" PRIu64 " cannot be less than the %s=" PRIu64, | ||
| AERON_URI_PUBLICATION_WINDOW_KEY, | ||
| value, | ||
| AERON_URI_MTU_LENGTH_KEY, | ||
| params->mtu_length); |
Check notice
Code scanning / CodeQL
Too many arguments to formatting function Note
Comment on lines
+138
to
+144
| AERON_SET_ERR( | ||
| EINVAL, | ||
| "%s=" PRIu64 " must not exceed half the %s=" PRIu64, | ||
| AERON_URI_PUBLICATION_WINDOW_KEY, | ||
| value, | ||
| AERON_URI_TERM_LENGTH_KEY, | ||
| params->term_length); |
Check notice
Code scanning / CodeQL
Too many arguments to formatting function Note
DarrylGamroth
pushed a commit
to New-Earth-Lab/aeron
that referenced
this pull request
Jan 22, 2025
…-logic#1717) * [C] add a call to init the new fields in the logbuffer metadata * [C] implement aeron_uri_get_publication_window_length_param * [C] implement the last 4 missing bits of metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.