Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): collect logs from Dask pods #850

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Alputer
Copy link
Member

@Alputer Alputer commented Nov 26, 2024

This PR adds the collection of logs for Dask pods, namely scheduler and workers.

Closes reanahub/reana-workflow-controller#610

@Alputer Alputer self-assigned this Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.07%. Comparing base (9baa183) to head (06fa887).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #850   +/-   ##
=======================================
  Coverage   31.07%   31.07%           
=======================================
  Files          26       26           
  Lines        2491     2491           
=======================================
  Hits          774      774           
  Misses       1717     1717           

Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely 👍

@@ -434,6 +434,16 @@ fluent-bit:
Refresh_Interval {{ .Values.inputConfig.refreshInterval }}
Rotate_Wait {{ .Values.inputConfig.rotateWait }}

[INPUT]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: ‏For the release notes, please use "Dask" with uppercase D in the commit log headline.

@Alputer Alputer changed the title feat(helm): collect logs from dask pods feat(helm): collect logs from Dask pods Jan 22, 2025
@tiborsimko tiborsimko merged commit 06fa887 into reanahub:master Jan 22, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

dask: capture live logs from running Dask scheduler and worker pods
2 participants