-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): collect logs from Dask pods #850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alputer
added a commit
to Alputer/reana
that referenced
this pull request
Jan 20, 2025
Alputer
force-pushed
the
dask-live-logs
branch
from
January 20, 2025 16:16
8200d19
to
df6b884
Compare
tiborsimko
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely 👍
tiborsimko
reviewed
Jan 22, 2025
@@ -434,6 +434,16 @@ fluent-bit: | |||
Refresh_Interval {{ .Values.inputConfig.refreshInterval }} | |||
Rotate_Wait {{ .Values.inputConfig.rotateWait }} | |||
|
|||
[INPUT] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: For the release notes, please use "Dask" with uppercase D in the commit log headline.
Alputer
force-pushed
the
dask-live-logs
branch
from
January 22, 2025 14:57
df6b884
to
06fa887
Compare
Alputer
changed the title
feat(helm): collect logs from dask pods
feat(helm): collect logs from Dask pods
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the collection of logs for Dask pods, namely scheduler and workers.
Closes reanahub/reana-workflow-controller#610