Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated function signatures to comply with new tensorflow requirements #2146

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

siyerp
Copy link
Contributor

@siyerp siyerp commented Aug 15, 2024

Description

I tried to run the sarsec notebook, but ran into issues because the function calls didn't comply with updated tensorflow requirements. I fixed the function calls so that they comply with updated requirements.

Related Issues

If you try running the sarsec notebook with a recent version of tensorflow, the training throws an error because tensorflow modules can only take non-tensor arguments if they are keyword arguments, so the 'training' argument, which is a boolean, throws an error unless it is a keyword argument.

References

<!--- References would be helpful to understand the changes. -->

Checklist:

  • [x ] I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • [x ] I have updated the documentation accordingly.
  • [x ] I have signed the commits, e.g. git commit -s -m "your commit message".
  • [x ] This PR is being made to staging branch AND NOT TO main branch.

miguelgfierro and others added 6 commits June 5, 2024 22:08
Staging to main: Fix bug with Sklearn and info for contributors
Staging to main: Fix to NewsRec, LightFM to extras, issue with scipy
Corrected docstring
…ments. -Subramanian Iyer <subramanian.iyer@paramount.com>
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this.

Please @siyerp notice that #2111 is in the works. If you want to collaborate on this effort, please let me know

@miguelgfierro miguelgfierro merged commit 61568e6 into recommenders-team:staging Aug 15, 2024
1 of 38 checks passed
@siyerp
Copy link
Contributor Author

siyerp commented Aug 15, 2024

@miguelgfierro I'd be interested in collaborating.

@miguelgfierro
Copy link
Collaborator

@siyerp would you be able to join the next Monday meeting:
Every Monday, we have a recurrent meeting, the time is 4.30-5pm (Central European Time): https://teams.microsoft.com/l/meetup-join/19%3acf53f267b15340de8867aa869ced4ed1%40thre[…]2c%22Oid%22%3a%22c798428d-eb18-456e-aed9-c2ecae3a8510%22%7d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants