When the id attribute is null (unsaved model), the sqid attribute sho…

…uld return null also and not throw an error.
red-explosion · May 31, 2024 · 183114e · 183114e
1 parent 2e7faa3
commit 183114e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/Concerns/HasSqids.php b/src/Concerns/HasSqids.php
@@ -18,7 +18,7 @@ protected function initializeHasSqids(): void
         $this->append(['sqid']);
     }
 
-    public function getSqidAttribute(): string
+    public function getSqidAttribute(): ?string
     {
         return Sqids::forModel(model: $this);
     }

diff --git a/src/Sqids.php b/src/Sqids.php
@@ -10,11 +10,15 @@
 
 class Sqids
 {
-    public static function forModel(Model $model): string
+    public static function forModel(Model $model): ?string
     {
         /** @var int $id */
         $id = $model->getKey();
 
+        if ($id === null) {
+            return null;
+        }
+
         $prefix = static::prefixForModel(model: $model::class);
         $separator = $prefix ? Config::separator() : null;
         $sqid = static::encodeId(model: $model::class, id: $id);