Skip to content

Commit

Permalink
small cleanup
Browse files Browse the repository at this point in the history
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
  • Loading branch information
lugi0 committed May 16, 2024
1 parent 4bd037f commit 6c0c3d9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 18 deletions.
13 changes: 0 additions & 13 deletions ods_ci/tests/Resources/Files/llm/vllm/query.json

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ ${VLLM_RESOURCES_DIRPATH}= ods_ci/tests/Resources/Files/llm/vllm
${DL_POD_FILEPATH}= ${VLLM_RESOURCES_DIRPATH}/download_model.yaml
${SR_FILEPATH}= ${VLLM_RESOURCES_DIRPATH}/vllm_servingruntime.yaml
${IS_FILEPATH}= ${VLLM_RESOURCES_DIRPATH}/vllm-gpt2_inferenceservice.yaml
${INFERENCE_INPUT}= @${VLLM_RESOURCES_DIRPATH}/query.json
${INFERENCE_URL}= http://localhost:8080/v1/chat/completions
${METRICS_URL}= http://localhost:8080/metrics/
${TEST_NS}= vllm-gpt2
@{SEARCH_METRICS}= vllm:cache_config_info
... vllm:num_requests_running
Expand All @@ -47,7 +44,7 @@ ${TEST_NS}= vllm-gpt2
*** Test Cases ***
Verify User Can Deploy A Model With Vllm Via CLI
[Documentation] Deploy a model (gpt2) using the vllm runtime and confirm that it's running
[Tags] Tier1 Sanity Resources-GPU ODS-XXX
[Tags] Tier1 Sanity Resources-GPU RHOAIENG-6264
${rc} ${out}= Run And Return Rc And Output oc apply -f ${DL_POD_FILEPATH}
Should Be Equal As Integers ${rc} ${0}
Wait For Pods To Succeed label_selector=gpt-download-pod=true namespace=${TEST_NS}
Expand All @@ -62,7 +59,7 @@ Verify User Can Deploy A Model With Vllm Via CLI

Verify Vllm Metrics Are Present
[Documentation] Confirm vLLM metrics are exposed in OpenShift metrics
[Tags] Tier1 Sanity Resources-GPU ODS-XXX
[Tags] Tier1 Sanity Resources-GPU RHOAIENG-6264
${host} = llm.Get KServe Inference Host Via CLI isvc_name=vllm-gpt2-openai namespace=${TEST_NS}

Check warning

Code scanning / Robocop

The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test

The assignment sign is not consistent within the file. Expected '=' but got ' =' instead
${rc} ${out}= Run And Return Rc And Output
... curl -ks ${host}/metrics/
Expand Down

0 comments on commit 6c0c3d9

Please sign in to comment.