Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kueue tests #1148

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Add Kueue tests #1148

merged 1 commit into from
Jan 31, 2024

Conversation

ChughShilpa
Copy link
Contributor

@ChughShilpa ChughShilpa requested a review from sutaakar January 23, 2024 08:46
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 23, 2024
View reviewed changes
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot


*** Keywords ***
Prepare Kueue E2E Test Suite

Check warning

Code scanning / Robocop

Keyword '{{ keyword_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test

Keyword 'Prepare Kueue E2E Test Suite' has too many keywords inside (14/10)
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot
${result} = Run Process git clone -b ${KUEUE_REPO_BRANCH} ${KUEUE_REPO_URL} ${KUEUE_DIR}
... shell=true stderr=STDOUT
Log To Console ${result.stdout}
IF ${result.rc} != 0

Check notice

Code scanning / Robocop

'{{ block_name }}' condition can be simplified Note test

'IF' condition can be simplified
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot

Enable Visibility Feature Gate
[Documentation] Enable Visibility Feature Gate
${return_code} = Run And Return Rc oc patch deployment kueue-controller-manager -n kueue-system --type 'json' -p '[{"op" : "add" ,"path" : "/spec/template/spec/containers/0/args/-" ,"value" : "--feature-gates=VisibilityOnDemand=true"}]'

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (246/120)
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
407 0 0 407 100

@ChughShilpa ChughShilpa force-pushed the kueue_e2e_tests branch 2 times, most recently from a8f482d to 1068f4e Compare January 23, 2024 09:05
@jiridanek jiridanek added needs testing Needs to be tested in Jenkins new test New test(s) added (PR will be listed in release-notes) labels Jan 23, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 24, 2024
View reviewed changes
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot

# Add label instance-type=on-demand on worker node
Log To Console Add label on worker node ...
${return_code} ${output} Run And Return Rc And Output oc get nodes -o name --selector=node-role.kubernetes.io/worker | tail -n1

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (140/120)
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot

# Add label instance-type=on-demand on worker node
Log To Console Add label on worker node ...
${return_code} ${output} Run And Return Rc And Output oc get nodes -o name --selector=node-role.kubernetes.io/worker | tail -n1

Check warning

Code scanning / Robocop

Local variable '{{ name }}' is overwritten before usage Warning test

Local variable '${return_code}' is overwritten before usage
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot

# Add label instance-type=on-demand on worker node
Log To Console Add label on worker node ...
${return_code} ${output} Run And Return Rc And Output oc get nodes -o name --selector=node-role.kubernetes.io/worker | tail -n1

Check warning

Code scanning / Robocop

The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test

The assignment sign is not consistent within the file. Expected ' =' but got '' instead
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot
# Add label instance-type=on-demand on worker node
Log To Console Add label on worker node ...
${return_code} ${output} Run And Return Rc And Output oc get nodes -o name --selector=node-role.kubernetes.io/worker | tail -n1
Set Suite Variable ${WORKER_NODE} ${output}

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Suite Variable can be replaced with VAR
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot
Comment on lines +55 to +68

Teardown Kueue E2E Test Suite

Check warning

Code scanning / Robocop

Invalid number of empty lines between keywords ({{ empty_lines }}/{{ allowed_empty_lines }}) Warning test

Invalid number of empty lines between keywords (2/1)
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot
Teardown Kueue E2E Test Suite
[Documentation] Teardown Kueue E2E Test Suite
Log To Console Uninstall Kueue ...
${return_code} ${output} Run And Return Rc And Output kubectl delete -k "github.com/kubernetes-sigs/kueue/config/default?ref=main" --ignore-not-found=true

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (167/120)
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 25, 2024
View reviewed changes
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot
... env:GOBIN=${JOB_GO_BIN}
... cwd=${KUEUE_DIR}
Log To Console ${result.stdout}
IF ${result.rc} != 0

Check notice

Code scanning / Robocop

IF can be replaced with inline IF Note test

IF can be replaced with inline IF
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot
... env:GOBIN=${JOB_GO_BIN}
... cwd=${KUEUE_DIR}
Log To Console ${result.stdout}
IF ${result.rc} != 0

Check notice

Code scanning / Robocop

'{{ block_name }}' condition can be simplified Note test

'IF' condition can be simplified
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot

Run Kueue E2E Test
[Documentation] Run Kueue E2E Test
[Arguments] ${test_name}

Check warning

Code scanning / Robocop

{{ var_or_arg }} '{{ variable_name }}' overwrites reserved variable '{{ reserved_variable }}' Warning test

Argument '${test_name}' overwrites reserved variable '${TEST_NAME}'
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot
... shell=true stderr=STDOUT
... env:PATH=%{PATH}:${JOB_GO_BIN}
Log To Console ${result.stdout}
IF ${result.rc} != 0

Check notice

Code scanning / Robocop

IF can be replaced with inline IF Note test

IF can be replaced with inline IF
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot
... shell=true stderr=STDOUT
... env:PATH=%{PATH}:${JOB_GO_BIN}
Log To Console ${result.stdout}
IF ${result.rc} != 0

Check notice

Code scanning / Robocop

'{{ block_name }}' condition can be simplified Note test

'IF' condition can be simplified
ods_ci/tests/Tests/650__distributed_workloads/test-run-kueue-e2e-tests.robot
${return_code} = Run And Return Rc oc patch deployment kueue-controller-manager -n kueue-system --type 'json' -p '[{"op" : "add" ,"path" : "/spec/template/spec/containers/0/args/-" ,"value" : "--feature-gates=VisibilityOnDemand=true"}]'
Should Be Equal As Integers ${return_code} 0 msg=Visiblity feature gate is not enabled

${return_code} = Run And Return Rc oc rollout status deployment/kueue-controller-manager -n kueue-system --timeout=3m

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (127/120)
sutaakar
sutaakar previously approved these changes Jan 25, 2024
View reviewed changes
@ChughShilpa
Copy link
Contributor Author

Verified in Jenkins build - rhods-pipeline-dw/213/

@ChughShilpa ChughShilpa added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Jan 31, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sutaakar sutaakar merged commit f6e366d into red-hat-data-services:master Jan 31, 2024
11 checks passed
@ChughShilpa ChughShilpa deleted the kueue_e2e_tests branch January 31, 2024 14:48
@ChughShilpa ChughShilpa restored the kueue_e2e_tests branch February 14, 2024 12:35
@ChughShilpa ChughShilpa deleted the kueue_e2e_tests branch December 26, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiripetrlik jiripetrlik jiripetrlik approved these changes

@sutaakar sutaakar sutaakar approved these changes

Assignees
No one assigned
Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChughShilpa @sutaakar @jiripetrlik @jiridanek