Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple Sanity failures in 2.6 #1158

Merged
merged 9 commits into from
Jan 30, 2024
Merged

Fix multiple Sanity failures in 2.6 #1158

merged 9 commits into from
Jan 30, 2024

Conversation

lugi0
Copy link
Contributor

@lugi0 lugi0 commented Jan 25, 2024

No description provided.

@lugi0 lugi0 added needs testing Needs to be tested in Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Jan 25, 2024
@lugi0 lugi0 self-assigned this Jan 25, 2024
@lugi0
Copy link
Contributor Author

lugi0 commented Jan 25, 2024

Testing in rhods-ci-pr-test/2387

@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
405 0 0 405 100

lugi0 added 6 commits January 30, 2024 12:12
@lugi0 @jiridanek
Fix various Sanity failures
fbe7231 
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
@lugi0 @jiridanek
Fixes
228428f 
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
@lugi0 @jiridanek
Add log level
c00e318 
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
@lugi0 @jiridanek
fix productbug for custom-image, log level for git test
00aa2f8 
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
@lugi0 @jiridanek
remove log level
58eb89d 
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
@lugi0 @jiridanek
add warn log for productbug in custom image test
898cdbf 
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
@jiridanek jiridanek force-pushed the fix/sanity_fixes_26 branch from 1899e68 to 898cdbf Compare January 30, 2024 11:12
@jiridanek
Copy link
Member

I clicked Update branch to get in this change to make GitHub Actions workflows green

@lugi0
Fix git test
10f2ecc 
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
@jstourac
Copy link
Member

Thank you, Luca - would you mind to also change the xpath for the Edit button on the custom image page?

https://github.com/red-hat-data-services/ods-ci/pull/1158/files#diff-889d47868c696256c924dc53fc3206c9d69eaf497b1a37ff8fe06df0c669f2e7R635

Instead of:

Click Element  xpath://td[.="${image_name}"]/../td[last()]//button/..//li[@id="${image_name}-edit-button"]

this one works:

Click Element  xpath://td[.="${image_name}"]/../td[last()]//button/..//button[@id="${image_name}-edit-button"]

lugi0 added 2 commits January 30, 2024 13:45
@lugi0
update button for editing custom images
cfe166c 
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
@lugi0
fix line length
eb3530c 
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
@lugi0 lugi0 added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Jan 30, 2024
@lugi0 lugi0 requested review from jstourac and bdattoma January 30, 2024 12:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lugi0 lugi0 merged commit c42b3c8 into red-hat-data-services:master Jan 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdattoma bdattoma bdattoma approved these changes

@jstourac jstourac jstourac approved these changes

Assignees

@lugi0 lugi0

Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lugi0 @jiridanek @jstourac @bdattoma