Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for Trusty Tests #1172

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

nehachopra27
Copy link
Contributor

  1. Adds wait between the trusty service install and verifying the trusty route is created or not.
  2. Adding wait betwen verifying the. metrics created and prometheus scraping data time.
  3. Renaming the bias metrics file

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
407 0 0 407 100

@diegolovison
Copy link
Contributor

In my opinion it should be something like:

    ${stopped} =    Set Variable    ${False}
    TRY
        WHILE    not ${stopped}    limit=${timeout}
            ${stopped} =  Run Keyword And Return Status  Run Keyword And Expect Error
            ...    Pods not found in search  OpenShiftLibrary.Search Pods
            ...    ${notebook_pod_name}  namespace=${NOTEBOOKS_NAMESPACE}
            Sleep    1s
        END
    EXCEPT    WHILE loop was aborted    type=start
        Delete User Notebook CR    ${TEST_USER_3.USERNAME}
        Fail    User Notebook pod was not removed within ${timeout}s
    END

The test suite is slow and adding a sleep with 60 seconds will make it even slower

Copy link
Contributor

@jgarciao jgarciao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Consider adding in a follow up PR a new keyword in ods_ci/tests/Resources/OCP.resource Wait Until Route Is Ready, that could use oc wait --for=condition=... --timeout=XXXs

@jgarciao jgarciao added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label Jan 31, 2024
@nehachopra27 nehachopra27 merged commit 98005d8 into red-hat-data-services:master Jan 31, 2024
11 checks passed
@nehachopra27 nehachopra27 deleted the delay branch January 31, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants