Add Test and Kw for authorino #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaykole
added
needs testing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Robocop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
bdattoma
reviewed
Apr 19, 2024
bdattoma
reviewed
Apr 19, 2024
Robot Results
|
bdattoma
reviewed
Apr 19, 2024
bdattoma
reviewed
Apr 19, 2024
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/LLMs/422__model_serving_llm.robot
Outdated
Show resolved
Hide resolved
bdattoma
reviewed
Apr 19, 2024
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/LLMs/422__model_serving_llm.robot
Outdated
Show resolved
Hide resolved
bdattoma
reviewed
Apr 19, 2024
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/LLMs/422__model_serving_llm_tgis.robot
Show resolved
Hide resolved
bdattoma
reviewed
Apr 19, 2024
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/LLMs/422__model_serving_llm_tgis.robot
Outdated
Show resolved
Hide resolved
bdattoma
reviewed
Apr 19, 2024
| ${inf_token} Create Inference Access Token ${test_namespace} ${DEFAULT_BUCKET_SA_NAME} | ||
| ${pod_name}= Get Pod Name namespace=${test_namespace} label_selector=serving.kserve.io/inferenceservice=${flan_model_name} | ||
| IF ${IS_KSERVE_RAW} Start Port-forwarding namespace=${test_namespace} pod_name=${pod_name} | ||
| Query Model Multiple Times model_name=${flan_model_name} runtime=${TGIS_RUNTIME_NAME} |
There was a problem hiding this comment.
could you add a Query to the model without passing the token and check it fails ?
There was a problem hiding this comment.
discussed offline and agreed on adding the test in the next PR
added 2 commits
April 20, 2024 23:23
Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
bdattoma
reviewed
Apr 22, 2024
Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
mwaykole
added
verified
Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
|
bdattoma
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.