Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyright typechecker to GitHub Actions #1425

Closed
wants to merge 1 commit into from

Conversation

jiridanek
Copy link
Member

No description provided.

Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jiridanek jiridanek requested review from kobihk and jstourac May 7, 2024 10:53
@jiridanek jiridanek self-assigned this May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
446 0 0 446 100

@@ -82,6 +82,9 @@ jobs:
- run: poetry run pyright
if: "!cancelled()"

- run: poetry run pyright
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need it since we have the same code in lines # 82-83

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏽 thanks, I'm blind

@jiridanek jiridanek closed this May 9, 2024
@jiridanek
Copy link
Member Author

This has been already merged before,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants