Fix: new home page issues #1428
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Robot Results
|
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDashboard.robot
Outdated
Show resolved
Hide resolved
| # Detect if we are ein the new (2.10) landing page instead in "Enable" | ||
| ${first_header}= Set Variable (//h1)[1] | ||
| Wait Until Element is Visible xpath:${first_header} | ||
| ${h1_text} Get Text xpath:${first_header} |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
FedeAlonso
requested review from
manosnoam,
jstourac,
bdattoma,
lugi0,
ConorOM1,
asanzgom and
jgarciao
and removed request for
jgarciao
FedeAlonso
added
the
enhancements
…ci into fix/new_home_page_issues
| [Documentation] Compare the h1 headers of the landing page with the expected ones | ||
| Wait Until Element Is Visible xpath:(//h1)[1] | ||
| ${h1_elements}= Get WebElements xpath://h1 | ||
| ${h1_texts}= Create List |
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
| Wait Until RHODS Dashboard ${dashboard_app} Is Visible | ||
| # Ideally the timeout would be an arg but Robot does not allow "normal" and "embedded" arguments | ||
| # Setting timeout to 30seconds since anything beyond that should be flagged as a UI bug | ||
| Wait Until Element is Visible xpath://div[contains(@class,'gallery')]/div//div[@class="pf-v5-c-card__title"]//*[text()="${dashboard_app}"] | ||
| Wait Until Element Is Visible xpath://div[contains(@class,'gallery')]/div//div[@class="pf-v5-c-card__title"]//*[text()="${dashboard_app}"] |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDashboard.robot
Outdated
Show resolved
Hide resolved
Co-authored-by: Noam Manos <nmanos@redhat.com>
|
In the last nightly (autotrigger-smoke/149) we had 37 failed test cases
Afte running the smoke from this branch (/rhods-smoke/5374), we have just 2 failed test cases. None related with the new landing page.
This PR is just a fix in order to enable again the nightlies. Maybe we should rethink the way we evaluate where is the user navigating, and if page by default should be "Enabled"