Add Training operator smoke tests to DW stack #1436
Conversation
sutaakar
requested review from
jiripetrlik,
Srihari1192,
abhijeet-dhumal and
ChughShilpa
and removed request for
Srihari1192 and
ChughShilpa
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| END | ||
|
|
||
| *** Keywords *** | ||
| Prepare Codeflare E2E Test Suite |
Check warning
Code scanning / Robocop
Missing documentation in '{{ name }}' keyword Warning test
| Wait Component Ready trainingoperator | ||
| RHOSi Setup | ||
|
|
||
| Teardown Codeflare E2E Test Suite |
Check warning
Code scanning / Robocop
Missing documentation in '{{ name }}' keyword Warning test
sutaakar
force-pushed
the
training-operator
branch
from
33648e3 to
d56bf02
Compare
Robot Results
|
There was a problem hiding this comment.
lgtm
Just one small change request, Instead of using %{ODH_NAMESPACE=redhat-ods-applications}, we can use
${APPLICATIONS_NAMESPACE} variable which fetches value from test variable file. Hence, our smoke tests run on ODH nightly as well as rhoai downstream .
https://github.com/red-hat-data-services/ods-ci/blob/master/ods_ci/test-variables.yml.example#L81
Currently our smoke tests fails in https://opendatascience-jenkins-csb-rhods.apps.ocp-c1.prod.psi.redhat.com/job/odh/job/autotrigger-smoke/
sutaakar
force-pushed
the
training-operator
branch
from
d56bf02 to
8229fc0
Compare
sutaakar
force-pushed
the
training-operator
branch
from
8229fc0 to
c11b949
Compare
|
| @@ -14,18 +12,18 @@ | |||
| [Tags] Smoke | |||
| ... DistributedWorkloads | |||
| Log To Console Waiting for kuberay-operator to be available | |||
| ${result} = Run Process oc wait --for\=condition\=Available --timeout\=60s -n ${ODH_NAMESPACE} deployment/kuberay-operator | |||
| ${result} = Run Process oc wait --for\=condition\=Available --timeout\=60s -n ${APPLICATIONS_NAMESPACE} deployment/kuberay-operator | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| @@ -34,35 +32,59 @@ | |||
| [Tags] Smoke | |||
| ... DistributedWorkloads | |||
| Log To Console Waiting for codeflare-operator-manager to be available | |||
| ${result} = Run Process oc wait --for\=condition\=Available --timeout\=60s -n ${ODH_NAMESPACE} deployment/codeflare-operator-manager | |||
| ${result} = Run Process oc wait --for\=condition\=Available --timeout\=60s -n ${APPLICATIONS_NAMESPACE} deployment/codeflare-operator-manager | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| Log To Console Waiting for kueue-controller-manager to be available | ||
| ${result} = Run Process oc wait --for\=condition\=Available --timeout\=300s -n ${ODH_NAMESPACE} deployment/kueue-controller-manager | ||
| ${result} = Run Process oc wait --for\=condition\=Available --timeout\=300s -n ${APPLICATIONS_NAMESPACE} deployment/kueue-controller-manager |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| [Tags] Smoke | ||
| ... DistributedWorkloads | ||
| Log To Console Waiting for kubeflow-training-operator to be available | ||
| ${result} = Run Process oc wait --for\=condition\=Available --timeout\=300s -n ${APPLICATIONS_NAMESPACE} deployment/kubeflow-training-operator |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| ${result} = Run Process oc wait --for\=condition\=Available --timeout\=300s -n ${APPLICATIONS_NAMESPACE} deployment/kubeflow-training-operator | ||
| ... shell=true stderr=STDOUT | ||
| Log To Console ${result.stdout} | ||
| IF ${result.rc} != 0 |
Check notice
Code scanning / Robocop
'{{ block_name }}' condition can be simplified Note test
|
@ChughShilpa thanks, good catch |
|
This needs to be fixed in other files too, though it is out of scope for this PR. |
Thanks Karel |
Yes right, i will raise the PR for this |
No description provided.