Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "FA100", # Missing from __future__ import annotations, but uses typing.Optional #1441

Merged
merged 1 commit into from
May 15, 2024

Conversation

jiridanek
Copy link
Member

This has been fixed previously by removing the typing.Optional from the files and replacing it with |. Let's just remove the suppression.

@jiridanek jiridanek requested review from kobihk and jstourac May 14, 2024 06:35
@jiridanek jiridanek self-assigned this May 14, 2024
@jiridanek jiridanek force-pushed the jd_missing_future branch from 1be530b to 49e04ff Compare May 14, 2024 06:38
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
455 0 0 455 100

… `typing.Optional`

Signed-off-by: Jiri Daněk <jdanek@redhat.com>
@jiridanek jiridanek force-pushed the jd_missing_future branch from 49e04ff to 66b0db4 Compare May 14, 2024 07:05
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jiridanek jiridanek enabled auto-merge (squash) May 14, 2024 13:59
@jiridanek jiridanek merged commit 1988e94 into red-hat-data-services:master May 15, 2024
8 checks passed
@jiridanek jiridanek deleted the jd_missing_future branch May 15, 2024 11:52
adolfo-ab pushed a commit to adolfo-ab/ods-ci that referenced this pull request May 21, 2024
… `typing.Optional` (red-hat-data-services#1441)

Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants