Check RHODS version before and after upgrade #1444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor upgrade test to check if version after upgrade is greater than the initial version. The previous approach that checked if the pods in the operator namespace were Pending after 10s was causing the test to fail, because the pods were usually already running before 10s. I think the right way to confirm if the upgrade was successful is to check the CSV version and that the pods in the operator namespace are running once the CSV version has been updated rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
jiridanek
force-pushed
the
refactor-upgrade
branch
from
dad22a0 to
6c4c101
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Should Be Equal As Integers ${return_code} 0 msg=Error while upgrading RHODS | ||
| Sleep 30s reason=wait for thirty seconds until old CSV is removed and new one is ready | ||
| ${is_version_gt} = Is RHODS Version Greater Than ${initial_version} | ||
| Run Keyword If ${is_version_gt} Fail RHODS version was not greater than initial version ${initial_version} |
Check warning
Code scanning / Robocop
'{{ statement_name }}' is deprecated since Robot Framework version {{ version }}, use '{{ alternative }}' instead Warning test
| [Documentation] Returns True if: | ||
| ... - RHODS version is greater or equal than ${initial_version} | ||
| [Arguments] ${initial_version} | ||
| ${ver} = Get RHODS version |
Check warning
Code scanning / Robocop
Keyword name '{{ keyword_name }}' does not follow case convention Warning test
Robot Results
|
Change Run Keyword If (deprecated) by IF, fix capitalization in Get RHODS Version keyword rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
adolfo-ab
changed the title
…odel response (red-hat-data-services#1447) Signed-off-by: Tarun Kumar <takumar@redhat.com>
add prod bug to tgis metrics test cases
… `typing.Optional` (red-hat-data-services#1441) Signed-off-by: Jiri Daněk <jdanek@redhat.com>
…nce()` for isinstance checks (red-hat-data-services#1443) This is no longer present in the checked files, so let's remove the suppression Signed-off-by: Jiri Daněk <jdanek@redhat.com>
…vices#1450) Signed-off-by: Tarun Kumar <takumar@redhat.com>
This started failing after this workaround red-hat-data-services#1432 ([1]). Originally the test expected that after logout and another login, the user is redirected to the original page where logout started. This doesn't happen anymore because of this new redirect to `enabled` paged in the mentioned workaround. Once the workaround is removed, we can delete the line added in this PR also. Though, the main point of the test isn't to check where the page is open after login, but the actual login names work as expected only. * [1] f9dfc88
…red-hat-data-services#1442) Signed-off-by: Jiri Daněk <jdanek@redhat.com>
…ata-services#1445) Allow user to provide custom-manifests Co-authored-by: Milind Waykole <mwaykole@redhat.com>
Reason is that this doesn't work when empty array is generated in test-variables.yml file. This should be easy to fix, but I'm lazy to do it. This is a followup of red-hat-data-services#1445.
On ODH the image name for Standard Data Science is actually named Jupyter Data Science. As such, we should change the expected image name when running on ODH and not on RHOAI. This should fix these two tests run in smoke: * `Verify Pipelines Integration With Elyra When Using Standard Data Science Image` * `Verify Workbench Images Have Multiple Versions`
This fixes following smoke test run on ODH: * `Verify Users Can Start, Stop, Launch And Delete A Workbench`
This was failing with ODH because there is a different network policy content. I think that the content in ODH is as expected, as such, I have updated our test to match this difference and work properly on both ODH and RHOAI installations.
* Add base test for vLLM and its metrics Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * Update ods_ci/tests/Resources/Files/llm/vllm/vllm_servingruntime.yaml Co-authored-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * reimplement using common keywords Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * Better handle missing metrics from UWM, change expected response format Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * small cleanup Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * Move keyword, some cleanup, comments Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> --------- Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> Co-authored-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
…ta-services#1461) * Bump pod timeout from 120 to 400 sec * Bump serverless operator retries from 20 to 100
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor upgrade test to check if version after upgrade is greater than the initial version. The previous approach that checked if the pods in the operator namespace were Pending after 10s was causing the test to fail, because the pods were already running before 10s, and playing with that sleep timer might make the test flaky. I think the right way to confirm if the upgrade has been successful is to check the CSV version and that the pods in the operator namespace are running once the CSV version has been updated
rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED