Allow user to provide custom-manifests to run ODS_CI on PR #1445
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -274,6 +274,7 @@ | |||
| END | |||
| END | |||
| Create DataScienceCluster CustomResource Using Test Variables | |||
| Apply Custom Manifest in DataScienceCluster CustomResource Using Test Variables | |||
Check warning
Code scanning / Robocop
Keyword name '{{ keyword_name }}' does not follow case convention Warning
| @@ -307,6 +308,21 @@ | |||
| END | |||
| END | |||
|
|
|||
| Apply Custom Manifest in DataScienceCluster CustomResource Using Test Variables | |||
Check warning
Code scanning / Robocop
Keyword name '{{ keyword_name }}' does not follow case convention Warning
| ${file_path} = Set Variable tasks/Resources/Files/ | ||
| FOR ${cmp} IN @{COMPONENT_LIST} | ||
| IF $cmp in $CUSTOM_MANIFESTS | ||
| ${manifest_string}= Convert To String ${CUSTOM_MANIFESTS}[${cmp}] |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning
Robot Results
|
|
i think you will have to do the changes in ods/jenkins and ods/odhcluster |
|
@aloganat @mwaykole I had already tested my changes againts rhods_smoke. |
|
Reason is that this doesn't work when empty array is generated in test-variables.yml file. This should be easy to fix, but I'm lazy to do it. This is a followup of red-hat-data-services#1445.
Reason is that this doesn't work when empty array is generated in test-variables.yml file. This should be easy to fix, but I'm lazy to do it. This is a followup of #1445.
…ata-services#1445) Allow user to provide custom-manifests Co-authored-by: Milind Waykole <mwaykole@redhat.com>
Reason is that this doesn't work when empty array is generated in test-variables.yml file. This should be easy to fix, but I'm lazy to do it. This is a followup of red-hat-data-services#1445.
Allow user to provide custom-manifests to run ODS_CI on PR.
Custom-manifest in below syntax should be define on
test-variable.yamlfile.Values of custom manifest could be passed using Jenkins as inline parameter(component1:repo_org:repo_name:branch_name:context_dir:source_path)