-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: add monitoring test to check targets are up and running #2165
enhancement: add monitoring test to check targets are up and running #2165
Conversation
[Arguments] ${pm_url} ${pm_token} ${username} ${password} | ||
${links}= Run curl --silent -X GET -H "Authorization:Bearer ${pm_token}" -u ${username}:${password} -k ${pm_url}/api/v1/targets | jq '.data.activeTargets[] | .scrapePool' #robocop:disable | ||
${links}= Replace String ${links} " ${EMPTY} | ||
@{links}= Split String ${links} \n |
Check notice
Code scanning / Robocop
Variable '{{ variable_name }}' may overwrite similar variable inside '{{ block_name }}' {{ block_type }}. Note that variables are case-insensitive, and also spaces and underscores are ignored. Note test
[Arguments] ${pm_url} ${pm_token} ${username} ${password} | ||
${links}= Run curl --silent -X GET -H "Authorization:Bearer ${pm_token}" -u ${username}:${password} -k ${pm_url}/api/v1/targets | jq '.data.activeTargets[] | select(.health == "up") | .scrapePool' #robocop:disable | ||
${links}= Replace String ${links} " ${EMPTY} | ||
@{links}= Split String ${links} \n |
Check notice
Code scanning / Robocop
Variable '{{ variable_name }}' may overwrite similar variable inside '{{ block_name }}' {{ block_type }}. Note that variables are case-insensitive, and also spaces and underscores are ignored. Note test
@@ -94,6 +94,36 @@ | |||
Should Contain ${list_values} ${resp.json()["data"]["result"][0]["value"][-1]} | |||
|
|||
|
|||
Test Targets Are Available And Up In RHOAI Prometheus |
Check warning
Code scanning / Robocop
Test case '{{ test_name }}' is too long ({{ test_length }}/{{ allowed_length }}) Warning test
@@ -94,6 +94,36 @@ | |||
Should Contain ${list_values} ${resp.json()["data"]["result"][0]["value"][-1]} | |||
|
|||
|
|||
Test Targets Are Available And Up In RHOAI Prometheus |
Check warning
Code scanning / Robocop
Test case '{{ test_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test
e06b459
to
73f1981
Compare
73f1981
to
a3ee87f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Nice!
Robot Results
|
Quality Gate passedIssues Measures |
/lgtm |
@CFSNM: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: asanzgom, CFSNM, MarianMacik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adding new test related to ticket: https://issues.redhat.com/browse/RHOAIENG-13066