Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add monitoring test to check targets are up and running #2165

Merged

Conversation

CFSNM
Copy link
Contributor

@CFSNM CFSNM commented Jan 9, 2025

Adding new test related to ticket: https://issues.redhat.com/browse/RHOAIENG-13066

@CFSNM CFSNM self-assigned this Jan 9, 2025
[Arguments] ${pm_url} ${pm_token} ${username} ${password}
${links}= Run curl --silent -X GET -H "Authorization:Bearer ${pm_token}" -u ${username}:${password} -k ${pm_url}/api/v1/targets | jq '.data.activeTargets[] | .scrapePool' #robocop:disable
${links}= Replace String ${links} " ${EMPTY}
@{links}= Split String ${links} \n

Check notice

Code scanning / Robocop

Variable '{{ variable_name }}' may overwrite similar variable inside '{{ block_name }}' {{ block_type }}. Note that variables are case-insensitive, and also spaces and underscores are ignored. Note test

Variable '@{links}' may overwrite similar variable inside 'Get Target Pools' Keyword. Note that variables are case-insensitive, and also spaces and underscores are ignored.
[Arguments] ${pm_url} ${pm_token} ${username} ${password}
${links}= Run curl --silent -X GET -H "Authorization:Bearer ${pm_token}" -u ${username}:${password} -k ${pm_url}/api/v1/targets | jq '.data.activeTargets[] | select(.health == "up") | .scrapePool' #robocop:disable
${links}= Replace String ${links} " ${EMPTY}
@{links}= Split String ${links} \n

Check notice

Code scanning / Robocop

Variable '{{ variable_name }}' may overwrite similar variable inside '{{ block_name }}' {{ block_type }}. Note that variables are case-insensitive, and also spaces and underscores are ignored. Note test

Variable '@{links}' may overwrite similar variable inside 'Get Target Pools Which Have State Up' Keyword. Note that variables are case-insensitive, and also spaces and underscores are ignored.
@@ -94,6 +94,36 @@
Should Contain ${list_values} ${resp.json()["data"]["result"][0]["value"][-1]}


Test Targets Are Available And Up In RHOAI Prometheus

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' is too long ({{ test_length }}/{{ allowed_length }}) Warning test

Test case 'Test Targets Are Available And Up In RHOAI Prometheus' is too long (27/20)
@@ -94,6 +94,36 @@
Should Contain ${list_values} ${resp.json()["data"]["result"][0]["value"][-1]}


Test Targets Are Available And Up In RHOAI Prometheus

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test

Test case 'Test Targets Are Available And Up In RHOAI Prometheus' has too many keywords inside (17/10)
@CFSNM CFSNM force-pushed the ods-179-prometheus-targets-up branch 2 times, most recently from e06b459 to 73f1981 Compare January 9, 2025 12:14
asanzgom
asanzgom previously approved these changes Jan 9, 2025
@CFSNM CFSNM force-pushed the ods-179-prometheus-targets-up branch from 73f1981 to a3ee87f Compare January 9, 2025 12:48
@openshift-ci openshift-ci bot removed the lgtm label Jan 9, 2025
@CFSNM CFSNM added the verified This PR has been tested with Jenkins label Jan 9, 2025
@CFSNM CFSNM requested a review from asanzgom January 9, 2025 12:49
Copy link
Contributor

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice!

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
594 0 0 594 100

@openshift-ci openshift-ci bot removed the lgtm label Jan 10, 2025
@CFSNM
Copy link
Contributor Author

CFSNM commented Jan 10, 2025

/lgtm

Copy link

openshift-ci bot commented Jan 10, 2025

@CFSNM: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm label Jan 10, 2025
@CFSNM CFSNM added the approved label Jan 10, 2025
Copy link

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: asanzgom, CFSNM, MarianMacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CFSNM CFSNM merged commit 7e9d65a into red-hat-data-services:master Jan 10, 2025
11 of 12 checks passed
@CFSNM CFSNM deleted the ods-179-prometheus-targets-up branch January 10, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants