Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime image upgrade test #975

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Add runtime image upgrade test #975

merged 5 commits into from
Oct 23, 2023

Conversation

bdattoma
Copy link
Contributor

This PR wants to ensure that if the Caikit+TGIS runtime gets upgraded, the already deployed models don't get affected by the upgrade.

  1. it deploys a model
  2. it changes the image URL
  3. checks that there is still one pod running
  4. checks the creation date of the pod remains unchanged (i.e., no restarts after runtime upgrade)
  5. checks the image URL used by the running pod didn't change

@bdattoma bdattoma added the new test New test(s) added (PR will be listed in release-notes) label Oct 10, 2023
@bdattoma bdattoma self-assigned this Oct 10, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 10, 2023
View reviewed changes
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot Fixed Show fixed Hide fixed
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot Show resolved Hide resolved
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot Dismissed Show dismissed Hide dismissed
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot Fixed Show fixed Hide fixed
@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
371 0 0 371 100

@bdattoma bdattoma added the verified This PR has been tested with Jenkins label Oct 10, 2023
@bdattoma
Copy link
Contributor Author

bdattoma commented Oct 10, 2023 •
edited
Loading

verified at rhods-ci-pr-test/2028 - SUCCESS
verified again at rhods-ci-pr-test/2030 after a code refactor - SUCCESS

FedeAlonso
FedeAlonso previously approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@FedeAlonso FedeAlonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jgarciao
jgarciao previously approved these changes Oct 17, 2023
View reviewed changes
@bdattoma
add runtime image upgrade test
066493c 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
add test doc
2f5a474 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
refactor for readability
bf2985c 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma bdattoma dismissed stale reviews from jgarciao and FedeAlonso via bf2985c October 19, 2023 09:14
@bdattoma bdattoma force-pushed the f/watsonx-runtimeup branch from d9e8c98 to bf2985c Compare October 19, 2023 09:14
@bdattoma
fix alerts
dc840af 
Signed-off-by: bdattoma <bdattoma@redhat.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 19, 2023
View reviewed changes
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__model_serving_llm.robot
${rc} ${caikitsha}= Run And Return Rc And Output
... oc get pod --selector serving.kserve.io/inferenceservice=${model_name} -n ${namespace} -ojson | jq '.items[].spec.containers[].image' | grep caikit-tgis # robocop: disable
Should Be Equal As Integers ${rc} ${0}
RETURN ${created_at} ${caikitsha}

Check warning

Code scanning / Robocop

File has too many lines ({{ lines_count }}/{{max_allowed_count }}) Warning test

File has too many lines (896/400)
@bdattoma bdattoma requested a review from FedeAlonso October 19, 2023 16:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jgarciao jgarciao requested a review from FedeAlonso October 23, 2023 08:05
@bdattoma bdattoma merged commit 671e85c into red-hat-data-services:master Oct 23, 2023
7 of 8 checks passed
@bdattoma bdattoma deleted the f/watsonx-runtimeup branch November 6, 2023 09:49
jgarciao pushed a commit to jgarciao/ods-ci that referenced this pull request Nov 6, 2023
@bdattoma @jgarciao
Add runtime image upgrade test (red-hat-data-services#975)
eb18277 
* add runtime image upgrade test

Signed-off-by: bdattoma <bdattoma@redhat.com>

* add test doc

Signed-off-by: bdattoma <bdattoma@redhat.com>

* refactor for readability

Signed-off-by: bdattoma <bdattoma@redhat.com>

* fix alerts

Signed-off-by: bdattoma <bdattoma@redhat.com>

---------

Signed-off-by: bdattoma <bdattoma@redhat.com>
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Nov 28, 2023
@bdattoma
Add runtime image upgrade test (red-hat-data-services#975)
a4ba6e0 
* add runtime image upgrade test

Signed-off-by: bdattoma <bdattoma@redhat.com>

* add test doc

Signed-off-by: bdattoma <bdattoma@redhat.com>

* refactor for readability

Signed-off-by: bdattoma <bdattoma@redhat.com>

* fix alerts

Signed-off-by: bdattoma <bdattoma@redhat.com>

---------

Signed-off-by: bdattoma <bdattoma@redhat.com>
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Jan 2, 2024
@bdattoma
Add runtime image upgrade test (red-hat-data-services#975)
416de22 
* add runtime image upgrade test

Signed-off-by: bdattoma <bdattoma@redhat.com>

* add test doc

Signed-off-by: bdattoma <bdattoma@redhat.com>

* refactor for readability

Signed-off-by: bdattoma <bdattoma@redhat.com>

* fix alerts

Signed-off-by: bdattoma <bdattoma@redhat.com>

---------

Signed-off-by: bdattoma <bdattoma@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeAlonso FedeAlonso FedeAlonso approved these changes

@jgarciao jgarciao jgarciao approved these changes

@jstourac jstourac Awaiting requested review from jstourac

@mwaykole mwaykole Awaiting requested review from mwaykole

@lugi0 lugi0 Awaiting requested review from lugi0

@tarukumar tarukumar Awaiting requested review from tarukumar

Assignees

@bdattoma bdattoma

Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdattoma @jgarciao @FedeAlonso