Fix custom image tests #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
lugi0
added
verified
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Robocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
diegolovison
previously requested changes
Oct 25, 2023
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
FedeAlonso
previously approved these changes
Oct 31, 2023
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
|
verified in rhods-ci-pr-test/2088 |
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
FedeAlonso
approved these changes
Oct 31, 2023
jstourac
approved these changes
Oct 31, 2023
jgarciao
approved these changes
Oct 31, 2023
jgarciao
dismissed
diegolovison’s stale review
Discussed in the automation meeting
jgarciao
pushed a commit
to jgarciao/ods-ci
that referenced
this pull request
Nov 6, 2023
* fix custom image tests Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * add local registry test Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * add small sleep Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * add sleep to wait for page load Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * remove comments, add polarion Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> --------- Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Nov 28, 2023
* fix custom image tests Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * add local registry test Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * add small sleep Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * add sleep to wait for page load Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * remove comments, add polarion Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> --------- Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Jan 2, 2024
* fix custom image tests Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * add local registry test Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * add small sleep Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * add sleep to wait for page load Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> * remove comments, add polarion Signed-off-by: Luca Giorgi <lgiorgi@redhat.com> --------- Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.