-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Typo in the variable name #994
Merged
lugi0
merged 1 commit into
red-hat-data-services:master
from
jstourac:accelleratorTestFix
Oct 30, 2023
Merged
[Fix] Typo in the variable name #994
lugi0
merged 1 commit into
red-hat-data-services:master
from
jstourac:accelleratorTestFix
Oct 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the errors in the GitHub dryrun action: ``` ------------------------------------------------------------------------------ Tests.Ods Dashboard.Model Serving.Model Serving Llm :: Collection ... | PASS | 16 tests, 16 passed, 0 failed ============================================================================== [ ERROR ] Error in file '/home/runner/work/ods-ci/ods-ci/ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/ModelServer.resource' on line 23: Setting variable '${SERVING_ACCELERATOR_MINUS_BUTTON_XPATH}' failed: Variable '${SERVING_INPUT_XPATH}' not found. Tests.Ods Dashboard.Model Serving.Model Serving Customruntimes :: Collectio... ============================================================================== Verify RHODS Admins Can Import A Custom Serving Runtime Template B... | PASS | ------------------------------------------------------------------------------ ```
jstourac
force-pushed
the
accelleratorTestFix
branch
from
October 27, 2023 20:24
a511a49
to
cf0e2ea
Compare
Kudos, SonarCloud Quality Gate passed! |
There are unrelated failing tests in For another approval - please check @lugi0 . Thanks |
FedeAlonso
approved these changes
Oct 30, 2023
lugi0
approved these changes
Oct 30, 2023
jgarciao
pushed a commit
to jgarciao/ods-ci
that referenced
this pull request
Nov 6, 2023
This fixes the errors in the GitHub dryrun action: ``` ------------------------------------------------------------------------------ Tests.Ods Dashboard.Model Serving.Model Serving Llm :: Collection ... | PASS | 16 tests, 16 passed, 0 failed ============================================================================== [ ERROR ] Error in file '/home/runner/work/ods-ci/ods-ci/ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/ModelServer.resource' on line 23: Setting variable '${SERVING_ACCELERATOR_MINUS_BUTTON_XPATH}' failed: Variable '${SERVING_INPUT_XPATH}' not found. Tests.Ods Dashboard.Model Serving.Model Serving Customruntimes :: Collectio... ============================================================================== Verify RHODS Admins Can Import A Custom Serving Runtime Template B... | PASS | ------------------------------------------------------------------------------ ```
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Nov 28, 2023
This fixes the errors in the GitHub dryrun action: ``` ------------------------------------------------------------------------------ Tests.Ods Dashboard.Model Serving.Model Serving Llm :: Collection ... | PASS | 16 tests, 16 passed, 0 failed ============================================================================== [ ERROR ] Error in file '/home/runner/work/ods-ci/ods-ci/ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/ModelServer.resource' on line 23: Setting variable '${SERVING_ACCELERATOR_MINUS_BUTTON_XPATH}' failed: Variable '${SERVING_INPUT_XPATH}' not found. Tests.Ods Dashboard.Model Serving.Model Serving Customruntimes :: Collectio... ============================================================================== Verify RHODS Admins Can Import A Custom Serving Runtime Template B... | PASS | ------------------------------------------------------------------------------ ```
ChughShilpa
pushed a commit
to ChughShilpa/ods-ci
that referenced
this pull request
Jan 2, 2024
This fixes the errors in the GitHub dryrun action: ``` ------------------------------------------------------------------------------ Tests.Ods Dashboard.Model Serving.Model Serving Llm :: Collection ... | PASS | 16 tests, 16 passed, 0 failed ============================================================================== [ ERROR ] Error in file '/home/runner/work/ods-ci/ods-ci/ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/ModelServer.resource' on line 23: Setting variable '${SERVING_ACCELERATOR_MINUS_BUTTON_XPATH}' failed: Variable '${SERVING_INPUT_XPATH}' not found. Tests.Ods Dashboard.Model Serving.Model Serving Customruntimes :: Collectio... ============================================================================== Verify RHODS Admins Can Import A Custom Serving Runtime Template B... | PASS | ------------------------------------------------------------------------------ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the errors in the GitHub dryrun action: