Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Typo in the variable name #994

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Oct 27, 2023

This fixes the errors in the GitHub dryrun action:

------------------------------------------------------------------------------
Tests.Ods Dashboard.Model Serving.Model Serving Llm :: Collection ... | PASS |
16 tests, 16 passed, 0 failed
==============================================================================
[ ERROR ] Error in file '/home/runner/work/ods-ci/ods-ci/ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/ModelServer.resource' on line 23: Setting variable '${SERVING_ACCELERATOR_MINUS_BUTTON_XPATH}' failed: Variable '${SERVING_INPUT_XPATH}' not found.
Tests.Ods Dashboard.Model Serving.Model Serving Customruntimes :: Collectio...
==============================================================================
Verify RHODS Admins Can Import A Custom Serving Runtime Template B... | PASS |
------------------------------------------------------------------------------

@jstourac jstourac requested a review from FedeAlonso October 27, 2023 20:23
This fixes the errors in the GitHub dryrun action:

```
------------------------------------------------------------------------------
Tests.Ods Dashboard.Model Serving.Model Serving Llm :: Collection ... | PASS |
16 tests, 16 passed, 0 failed
==============================================================================
[ ERROR ] Error in file '/home/runner/work/ods-ci/ods-ci/ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/ModelServer.resource' on line 23: Setting variable '${SERVING_ACCELERATOR_MINUS_BUTTON_XPATH}' failed: Variable '${SERVING_INPUT_XPATH}' not found.
Tests.Ods Dashboard.Model Serving.Model Serving Customruntimes :: Collectio...
==============================================================================
Verify RHODS Admins Can Import A Custom Serving Runtime Template B... | PASS |
------------------------------------------------------------------------------
```
@jstourac jstourac force-pushed the accelleratorTestFix branch from a511a49 to cf0e2ea Compare October 27, 2023 20:24
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jstourac
Copy link
Member Author

There are unrelated failing tests in dryrun but the ERROR messages has gone - this should be good to merge.

For another approval - please check @lugi0 . Thanks

@lugi0 lugi0 merged commit 465457f into red-hat-data-services:master Oct 30, 2023
7 of 8 checks passed
@jstourac jstourac deleted the accelleratorTestFix branch October 30, 2023 08:39
jgarciao pushed a commit to jgarciao/ods-ci that referenced this pull request Nov 6, 2023
This fixes the errors in the GitHub dryrun action:

```
------------------------------------------------------------------------------
Tests.Ods Dashboard.Model Serving.Model Serving Llm :: Collection ... | PASS |
16 tests, 16 passed, 0 failed
==============================================================================
[ ERROR ] Error in file '/home/runner/work/ods-ci/ods-ci/ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/ModelServer.resource' on line 23: Setting variable '${SERVING_ACCELERATOR_MINUS_BUTTON_XPATH}' failed: Variable '${SERVING_INPUT_XPATH}' not found.
Tests.Ods Dashboard.Model Serving.Model Serving Customruntimes :: Collectio...
==============================================================================
Verify RHODS Admins Can Import A Custom Serving Runtime Template B... | PASS |
------------------------------------------------------------------------------
```
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Nov 28, 2023
This fixes the errors in the GitHub dryrun action:

```
------------------------------------------------------------------------------
Tests.Ods Dashboard.Model Serving.Model Serving Llm :: Collection ... | PASS |
16 tests, 16 passed, 0 failed
==============================================================================
[ ERROR ] Error in file '/home/runner/work/ods-ci/ods-ci/ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/ModelServer.resource' on line 23: Setting variable '${SERVING_ACCELERATOR_MINUS_BUTTON_XPATH}' failed: Variable '${SERVING_INPUT_XPATH}' not found.
Tests.Ods Dashboard.Model Serving.Model Serving Customruntimes :: Collectio...
==============================================================================
Verify RHODS Admins Can Import A Custom Serving Runtime Template B... | PASS |
------------------------------------------------------------------------------
```
ChughShilpa pushed a commit to ChughShilpa/ods-ci that referenced this pull request Jan 2, 2024
This fixes the errors in the GitHub dryrun action:

```
------------------------------------------------------------------------------
Tests.Ods Dashboard.Model Serving.Model Serving Llm :: Collection ... | PASS |
16 tests, 16 passed, 0 failed
==============================================================================
[ ERROR ] Error in file '/home/runner/work/ods-ci/ods-ci/ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/ModelServer.resource' on line 23: Setting variable '${SERVING_ACCELERATOR_MINUS_BUTTON_XPATH}' failed: Variable '${SERVING_INPUT_XPATH}' not found.
Tests.Ods Dashboard.Model Serving.Model Serving Customruntimes :: Collectio...
==============================================================================
Verify RHODS Admins Can Import A Custom Serving Runtime Template B... | PASS |
------------------------------------------------------------------------------
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants