Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds custom config to verify dedup feature #11055

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Adds custom config to verify dedup feature #11055

merged 1 commit into from
Dec 26, 2024

Conversation

udaysk23
Copy link
Contributor

@udaysk23 udaysk23 requested review from a team as code owners December 17, 2024 09:28
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Dec 17, 2024
@udaysk23 udaysk23 added High Priority High priority issues MCG Multi Cloud Gateway / NooBaa related issues Squad/Red labels Dec 17, 2024
@udaysk23 udaysk23 force-pushed the dedup_issue branch 2 times, most recently from 7de861e to 125e171 Compare December 17, 2024 09:36
@udaysk23
Adds custom config to verify dedup feature
71279ae 
Signed-off-by: Uday Kurundwade <Uday.Shamrao.Kurundwade@ibm.com>
ocs-ci
ocs-ci reviewed Dec 17, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ukurundw-66
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/object/mcg/test_write_to_bucket.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job UNSTABLE (some or all tests failed).

@udaysk23
Copy link
Contributor Author

The test case failed in last jenkins PR validation run is not related to this PR, Kindly ignore that failure

@udaysk23 udaysk23 added the Verified Mark when PR was verified and log provided label Dec 17, 2024
ypersky1980
ypersky1980 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@ypersky1980 ypersky1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Dec 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: keesturam, sagihirshfeld, udaysk23, ypersky1980

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@keesturam keesturam merged commit 1b86d4c into red-hat-storage:master Dec 26, 2024
6 of 7 checks passed
paraggit pushed a commit to paraggit/ocs-ci that referenced this pull request Jan 6, 2025
@udaysk23 @paraggit
Adds custom config to verify dedup feature (red-hat-storage#11055)
67ae8d5 
Signed-off-by: Uday Kurundwade <Uday.Shamrao.Kurundwade@ibm.com>
@udaysk23
Copy link
Contributor Author

udaysk23 commented Jan 8, 2025

/cherrypick release-4.17

@openshift-cherrypick-robot
Copy link
Collaborator

@udaysk23: new pull request created: #11125

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 8, 2025
Open
@udaysk23 udaysk23 mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@ypersky1980 ypersky1980 ypersky1980 approved these changes

@sagihirshfeld sagihirshfeld sagihirshfeld approved these changes

@keesturam keesturam keesturam approved these changes

@mashetty330 mashetty330 Awaiting requested review from mashetty330

Assignees

@keesturam keesturam

@sagihirshfeld sagihirshfeld

@ypersky1980 ypersky1980

Labels
High Priority High priority issues lgtm MCG Multi Cloud Gateway / NooBaa related issues size/S PR that changes 10-29 lines Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@udaysk23 @openshift-cherrypick-robot @keesturam @sagihirshfeld @ocs-ci @ypersky1980