Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded RBACs for ArgoCD #4802

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unneeded RBACs for ArgoCD #4802

wants to merge 1 commit into from
+0 −279

Conversation

hugares
Copy link
Contributor

@hugares hugares commented Oct 25, 2024

These RBACs are granting permission to a service account that is not used.

@hugares hugares requested a review from gbenhaim October 25, 2024 19:54
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@hugares hugares force-pushed the hares-cleanup-perm branch from 039ad57 to 3e7e690 Compare October 28, 2024 14:04
@hugares hugares marked this pull request as ready for review October 28, 2024 14:05
@openshift-ci openshift-ci bot requested review from davidmogar and elsony October 28, 2024 14:05
@hugares hugares requested review from mshaposhnik, bamachrn, manish-jangra and eisraeli and removed request for davidmogar and elsony October 28, 2024 14:05
@hugares hugares force-pushed the hares-cleanup-perm branch from 3e7e690 to 618e8c3 Compare October 28, 2024 18:27
@openshift-ci openshift-ci bot removed the lgtm label Oct 28, 2024
@gbenhaim
Copy link
Member

/approve

@gbenhaim
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 28, 2024
@hugares
Copy link
Contributor Author

hugares commented Oct 29, 2024

/retest

manish-jangra
manish-jangra approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@manish-jangra manish-jangra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gbenhaim, hugares, manish-jangra, mshaposhnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@manish-jangra
Copy link
Contributor

/test appstudio-e2e-tests

@hugares
Remove unneeded RBACs for ArgoCD
e97dc55 
These RBACs are granting permission to a service account that is not
used.

Signed-off-by: Hugo Ares <hares@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Nov 13, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 13, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 13, 2024

@hugares: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-e2e-tests e97dc55 link true /test appstudio-e2e-tests
ci/prow/appstudio-upgrade-tests e97dc55 link false /test appstudio-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manish-jangra manish-jangra manish-jangra approved these changes

@mshaposhnik mshaposhnik mshaposhnik approved these changes

@gbenhaim gbenhaim Awaiting requested review from gbenhaim

@bamachrn bamachrn Awaiting requested review from bamachrn

@eisraeli eisraeli Awaiting requested review from eisraeli

Assignees

@gbenhaim gbenhaim

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugares @gbenhaim @manish-jangra @mshaposhnik