Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup additional resources #5224

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Backup additional resources #5224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions components/backup/base/member/schedules/backup-tenants-schedule.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,13 @@ spec:
- secrets
- snapshots.appstudio.redhat.com
- serviceaccounts
- rolebindings
- namespaces
- imagerepositories.appstudio.redhat.com
- repositories.pipelinesascode.tekton.dev
- releases.appstudio.redhat.com
- releaseplans.appstudio.redhat.com
- releaseplanadmissions.appstudio.redhat.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe backing up specific resources was a wrong approach to start with. We will always be in catch up mode, i.e. adding resource to back up after trying to recover them and realizing that they are not in the backup. Should we back up all resources in the namespaces that are not excluded instead?

We will use more storage but at least we will be sure that a new added resources will not be missing from backup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check if it can backup everything from the namespace. It sounds a bit tricky.

storageLocation: velero-aws-1
ttl: 720h0m0s
useOwnerReferencesInBackup: true
Loading