namespace-lister: disable configmap name suffix hashing #5288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when we generate the configmap for the proxy, kustomize will automatically append a hash to its name. This breaks the proxy deployment, since it looks for a configmap with a specific name. We can fix this either by disabling name suffix hashing or by injecting the name via a replacement. The former is easier to implement, so opt to implement that method. Signed-off-by: Andy Sadler <ansadler@redhat.com>
|
FWIW, I'm opting to fix proxy here since I don't have permissions to do port-forwarding on the staging clusters. |
filariow
approved these changes
Jan 16, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filariow, sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit e412d98
into
redhat-appstudio:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we generate the configmap for the proxy, kustomize will automatically append a hash to its name. This breaks the proxy deployment, since it looks for a configmap with a specific name.
We can fix this either by disabling name suffix hashing or by injecting the name via a replacement. The former is easier to implement, so opt to implement that method.