Skip to content

Commit

Permalink
Fix arg spec failure (#551)
Browse files Browse the repository at this point in the history
* Fix arg spec failure

* add changelog

* fix broken link
  • Loading branch information
Tompage1994 authored Mar 24, 2023
1 parent b07941a commit 040c17c
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 1 addition & 0 deletions changelogs/fragments/arg_spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ bugfixes:
- Removed master_role_example as no longer required (this wasn't a functional role)
- Added argument_spec for all roles
- Fixed variable definitions in readmes
- Fixed issue in filetree_read where arg spec incorrect and caused failure (#550)
...
2 changes: 0 additions & 2 deletions roles/filetree_read/meta/argument_specs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,10 @@ argument_specs:
options:
orgs:
type: str
default: Acme
required: true
description: This variable sets the organization where should be applied the configuration.
dir_orgs_vars:
type: str
default: orgs_vars
required: true
description: This variable sets the directory path where the variables will be store.
env:
Expand Down
2 changes: 1 addition & 1 deletion tests/playbooks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ This procedure has been tested with **gitlab** git server

You have make the following configurations in order to configure CD integration:

1. Configure a Project and a job template with [webhook](https://docs.ansible.com/automation-controller/latest/html/userguide/webhooks.html#id2) property enabled in the Controller pointing to the playbook in charge of CD, you can find an example [here](https://github.com/redhat-cop/controller_configuration/blob/devel/.github/tests/playbooks/cd_gitlab_webhook_trigger.yml).
1. Configure a Project and a job template with [webhook](https://docs.ansible.com/automation-controller/latest/html/userguide/webhooks.html#id2) property enabled in the Controller pointing to the playbook in charge of CD, you can find an example [here](https://github.com/redhat-cop/controller_configuration/blob/devel/tests/playbooks/cd_gitlab_webhook_trigger.yml).

2. Configure [project webhook](https://docs.gitlab.com/ee/user/project/integrations/webhook_events.html) on the project where defined configurations are hosted.

Expand Down

0 comments on commit 040c17c

Please sign in to comment.