fixing roles to have label working (#946)

* modified:   roles/dispatch/README.md
	modified:   roles/gateway_users/tasks/main.yml
	modified:   tests/configs/user_accounts.yml

* modified:   roles/gateway_applications/tasks/main.yml
	modified:   roles/gateway_authenticator_maps/tasks/main.yml
	modified:   roles/gateway_authenticators/tasks/main.yml
	modified:   roles/gateway_http_ports/tasks/main.yml
	modified:   roles/gateway_organizations/tasks/main.yml
	modified:   roles/gateway_routes/tasks/main.yml
	modified:   roles/gateway_service_clusters/tasks/main.yml
	modified:   roles/gateway_service_keys/tasks/main.yml
	modified:   roles/gateway_service_nodes/tasks/main.yml
	modified:   roles/gateway_services/tasks/main.yml
	modified:   roles/gateway_teams/tasks/main.yml
	modified:   roles/gateway_users/tasks/main.yml
	modified:   roles/hub_collection/tasks/main.yml
	modified:   roles/hub_collection_repository/tasks/main.yml
	modified:   roles/hub_collection_repository_sync/tasks/main.yml
	modified:   roles/hub_ee_image/tasks/main.yml
	modified:   roles/hub_ee_registry/tasks/main.yml
	modified:   roles/hub_ee_registry_index/tasks/main.yml
	modified:   roles/hub_ee_registry_sync/tasks/main.yml
	modified:   roles/hub_ee_repository/tasks/main.yml
	modified:   roles/hub_ee_repository_sync/tasks/main.yml
	modified:   roles/hub_group/tasks/main.yml
	modified:   roles/hub_group_roles/tasks/main.yml
	modified:   roles/hub_namespace/tasks/main.yml
	modified:   roles/hub_role/tasks/main.yml
	modified:   roles/hub_user/tasks/main.yml

* modified:   roles/gateway_routes/tasks/main.yml
	modified:   roles/gateway_service_clusters/tasks/main.yml
	modified:   roles/gateway_teams/tasks/main.yml
	modified:   roles/gateway_users/tasks/main.yml

* modified:   roles/gateway_authenticator_maps/tasks/main.yml

roles/gateway_applications/tasks/main.yml

@@ -34,6 +34,7 @@
   register: __gateway_applications_job_async
   changed_when: not __gateway_applications_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__gateway_application_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 
 - name: Applications | Wait for finish the configuration
@@ -50,5 +51,6 @@
   when: __gateway_applications_job_async_results_item.ansible_job_id is defined
   no_log: "{{ applications_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__gateway_applications_job_async_results_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 ...

roles/gateway_authenticator_maps/tasks/main.yml

@@ -32,6 +32,7 @@
   register: __gateway_authenticator_maps_job_async
   changed_when: not __gateway_authenticator_maps_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__gateway_authenticator_maps_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 
 - name: Authenticator Map | Wait for finish the configuration
@@ -48,5 +49,6 @@
   when: __gateway_authenticator_maps_job_async_results_item.ansible_job_id is defined
   no_log: "{{ gateway_authenticator_maps_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__gateway_authenticator_maps_job_async_results_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 ...

roles/gateway_authenticators/tasks/main.yml

@@ -30,6 +30,7 @@
   register: __gateway_authenticators_job_async
   changed_when: not __gateway_authenticators_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__gateway_authenticators_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 
 - name: Authenticators | Wait for finish the configuration
@@ -46,5 +47,6 @@
   when: __gateway_authenticators_job_async_results_item.ansible_job_id is defined
   no_log: "{{gateway_authenticators_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__gateway_authenticators_job_async_results_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 ...

roles/gateway_http_ports/tasks/main.yml

@@ -26,6 +26,7 @@
   register: __gateway_http_ports_job_async
   changed_when: not __gateway_http_ports_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__gateway_http_ports_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 
 - name: Http Ports | Wait for finish the configuration
@@ -42,5 +43,6 @@
   when: __gateway_http_ports_job_async_results_item.ansible_job_id is defined
   no_log: "{{ gateway_http_ports_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__gateway_http_ports_job_async_results_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 ...

roles/gateway_organizations/tasks/main.yml

@@ -24,6 +24,7 @@
   register: __gateway_organizations_job_async
   changed_when: not __gateway_organizations_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__gateway_organizations_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 
 - name: Organizations | Wait for finish the configuration
@@ -40,5 +41,6 @@
   when: __gateway_organizations_job_async_results_item.ansible_job_id is defined
   no_log: "{{ gateway_organizations_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__gateway_organizations_job_async_results_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 ...

roles/gateway_routes/tasks/main.yml

@@ -32,6 +32,7 @@
   register: __gateway_routes_job_async
   changed_when: not __gateway_routes_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__gateway_routes_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 
 - name: Routes | Wait for finish the configuration
@@ -48,5 +49,6 @@
   when: __gateway_routes_job_async_results_item.ansible_job_id is defined
   no_log: "{{ gateway_routes_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__gateway_routes_job_async_results_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 ...

roles/gateway_service_clusters/tasks/main.yml

@@ -34,6 +34,7 @@
   register: __gateway_service_clusters_job_async
   changed_when: not __gateway_service_clusters_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__gateway_service_clusters_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 
 - name: Service Clusters | Wait for finish the configuration
@@ -50,5 +51,6 @@
   when: __gateway_service_clusters_job_async_results_item.ansible_job_id is defined
   no_log: "{{ gateway_service_clusters_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__gateway_service_clusters_job_async_results_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 ...

roles/gateway_service_keys/tasks/main.yml

@@ -29,6 +29,7 @@
   register: __gateway_service_keys_job_async
   changed_when: not __gateway_service_keys_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__gateway_service_keys_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 
 - name: Service Keys | Wait for finish the configuration
@@ -45,5 +46,6 @@
   when: __gateway_service_keys_job_async_results_item.ansible_job_id is defined
   no_log: "{{ gateway_gateway_service_keys_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__gateway_service_keys_job_async_results_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 ...

roles/gateway_service_nodes/tasks/main.yml

@@ -26,6 +26,7 @@
   register: __gateway_service_nodes_job_async
   changed_when: not __gateway_service_nodes_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__gateway_service_nodes_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 
 - name: Service Nodes | Wait for finish the configuration
@@ -42,5 +43,6 @@
   when: __gateway_service_nodes_job_async_results_item.ansible_job_id is defined
   no_log: "{{ service_nodes_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__gateway_service_nodes_job_async_results_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 ...

roles/gateway_services/tasks/main.yml

@@ -33,6 +33,7 @@
   register: __gateway_services_job_async
   changed_when: not __gateway_services_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__gateway_services_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 
 - name: Services | Wait for finish the configuration
@@ -49,5 +50,6 @@
   when: __gateway_services_job_async_results_item.ansible_job_id is defined
   no_log: "{{ services_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__gateway_services_job_async_results_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 ...

roles/gateway_teams/tasks/main.yml

@@ -26,6 +26,7 @@
   register: __gateway_teams_job_async
   changed_when: not __gateway_teams_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__gateway_teams_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 
 - name: Teams | Wait for finish the configuration
@@ -42,5 +43,6 @@
   when: __gateway_teams_job_async_results_item.ansible_job_id is defined
   no_log: "{{ platform_teams_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__gateway_teams_job_async_results_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 ...

roles/gateway_users/tasks/main.yml

@@ -32,6 +32,7 @@
   register: __gateway_user_accounts_job_async
   changed_when: not __gateway_user_accounts_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__gateway_user_accounts_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 
 - name: Users | Wait for finish the configuration
@@ -48,5 +49,6 @@
   when: __gateway_user_accounts_job_async_results_item.ansible_job_id is defined
   no_log: "{{ users_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__gateway_user_accounts_job_async_results_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: "{{ aap_configuration_async_dir | default(omit) }}"
 ...

roles/hub_collection/tasks/main.yml

@@ -16,17 +16,17 @@
 
 - name: Update or destroy Automation Hub Collection
   ansible.hub.ah_collection:
-    namespace:             "{{ __collection.namespace }}"
-    name:                  "{{ __collection.name }}"
-    version:               "{{ __collection.version | default(omit) }}"
-    path:                  "{{ __collection.path | default(omit) }}"
-    repository:            "{{ __collection.repository | default(omit) }}"
-    wait:                  "{{ __collection.wait | default(omit) }}"
-    auto_approve:          "{{ __collection.auto_approve | default(omit) }}"
-    timeout:               "{{ __collection.timeout | default(omit) }}"
-    interval:              "{{ __collection.interval | default(omit) }}"
-    overwrite_existing:    "{{ __collection.overwrite_existing | default(omit) }}"
-    state:                 "{{ __collection.state | default('present') }}"
+    namespace:             "{{ __collections_item.namespace }}"
+    name:                  "{{ __collections_item.name }}"
+    version:               "{{ __collections_item.version | default(omit) }}"
+    path:                  "{{ __collections_item.path | default(omit) }}"
+    repository:            "{{ __collections_item.repository | default(omit) }}"
+    wait:                  "{{ __collections_item.wait | default(omit) }}"
+    auto_approve:          "{{ __collections_item.auto_approve | default(omit) }}"
+    timeout:               "{{ __collections_item.timeout | default(omit) }}"
+    interval:              "{{ __collections_item.interval | default(omit) }}"
+    overwrite_existing:    "{{ __collections_item.overwrite_existing | default(omit) }}"
+    state:                 "{{ __collections_item.state | default('present') }}"
     ah_host:               "{{ aap_hostname | default(omit) }}"
     ah_username:          "{{ aap_username | default(omit) }}"
     ah_password:           "{{ aap_password | default(omit) }}"
@@ -36,7 +36,7 @@
     request_timeout:       "{{ aap_request_timeout | default(omit) }}"
   loop: "{{ ah_collections }}"
   loop_control:
-    loop_var: "__collection"
+    loop_var: __collections_item
     label: "{{ __operation.verb }} the label {{ __ah_configuration_collection__item.name }} to Controller"
     pause: "{{ ah_configuration_collection__loop_delay }}"
   no_log: "{{ ah_configuration_collection_secure_logging }}"
@@ -45,6 +45,7 @@
   register: __collections_job_async
   changed_when: not __collections_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__collections_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: '{{ aap_configuration_async_dir }}'
 
 - name: Sleep for 10 seconds and continue with play
@@ -61,9 +62,10 @@
   loop: "{{ __collections_job_async.results }}"
   loop_control:
     loop_var: __collections_job_async_result_item
-    label: "{{ __operation.verb }} Label {{ __collections_job_async_result_item.__collection.name }} | Wait for finish the Label {{ __operation.action }}"
+    label: "{{ __operation.verb }} Label {{ __collections_job_async_result_item.__collections_item.name }} | Wait for finish the Label {{ __operation.action }}"
   when: __collections_job_async_result_item.ansible_job_id is defined
   no_log: "{{ ah_configuration_collection_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__collections_job_async_result_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: '{{ aap_configuration_async_dir }}'
 ...

roles/hub_collection_repository/tasks/main.yml

@@ -22,7 +22,7 @@
     request_timeout:          "{{ aap_request_timeout | default(omit) }}"
   loop: "{{ ah_collection_repositories }}"
   loop_control:
-    loop_var: "__collection_repository_item"
+    loop_var: __collection_repository_item
     label: "{{ __operation.verb }} the label {{ __ah_configuration_collection_repository__item.name }} to Controller"
     pause: "{{ ah_configuration_collection_repository__loop_delay }}"
   no_log: "{{ ah_configuration_collection_repository_secure_logging }}"
@@ -31,6 +31,7 @@
   register: __collection_repository_job_async
   changed_when: not __collection_repository_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__collection_repository_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: '{{ aap_configuration_async_dir }}'
 
 - name: "Create Repository | Wait for finish the repository creation"
@@ -47,6 +48,7 @@
   when: __collection_repository_job_async_result_item.ansible_job_id is defined
   no_log: "{{ ah_configuration_collection_repository_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__collection_repository_job_async_result_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: '{{ aap_configuration_async_dir }}'
 
 ...

roles/hub_collection_repository_sync/tasks/main.yml

@@ -14,7 +14,7 @@
     request_timeout:          "{{ aap_request_timeout | default(omit) }}"
   loop: "{{ ah_collection_repositories }}"
   loop_control:
-    loop_var: "__collection_repository_sync_item"
+    loop_var: __collection_repository_sync_item
     label: "{{ __operation.verb }} the label {{ __ah_configuration_collection_repository_sync__item.name }} to Controller"
     pause: "{{ ah_configuration_collection_repository_sync__loop_delay }}"
   no_log: "{{ ah_configuration_collection_repository_sync_secure_logging }}"
@@ -23,6 +23,7 @@
   register: __collection_repository_sync_job_async
   changed_when: not __collection_repository_sync_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__collection_repository_sync_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: '{{ aap_configuration_async_dir }}'
 
 - name: "Sync Repository | Wait for finish the repository sync"
@@ -39,6 +40,7 @@
   when: __collection_repository_sync_job_async_result_item.ansible_job_id is defined
   no_log: "{{ ah_configuration_collection_repository_sync_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__collection_repository_sync_job_async_result_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: '{{ aap_configuration_async_dir }}'
 
 ...

roles/hub_ee_image/tasks/main.yml

@@ -16,7 +16,7 @@
     request_timeout:  "{{ aap_request_timeout | default(omit) }}"
   loop: "{{ ah_ee_images }}"
   loop_control:
-    loop_var: "__ee_image_item"
+    loop_var: __ee_image_item
     label: "{{ __operation.verb }} the label {{ __ah_configuration_ee_image__item.name }} to Controller"
     pause: "{{ ah_configuration_ee_image__loop_delay }}"
   no_log: "{{ ah_configuration_ee_image_secure_logging }}"
@@ -25,6 +25,7 @@
   register: __ee_images_job_async
   changed_when: not __ee_images_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__ee_image_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: '{{ aap_configuration_async_dir }}'
 
 - name: "Create EE Image | Wait for finish the ee_image creation"
@@ -41,5 +42,6 @@
   when: __ee_images_job_async_result_item.ansible_job_id is defined
   no_log: "{{ ah_configuration_ee_image_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__ee_images_job_async_result_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: '{{ aap_configuration_async_dir }}'
 ...

roles/hub_ee_registry/tasks/main.yml

@@ -22,7 +22,7 @@
     proxy_password:         "{{ __ee_registry_item.proxy_password | default(proxy_password | default(omit)) }}"
   loop: "{{ ah_ee_registries }}"
   loop_control:
-    loop_var: "__ee_registry_item"
+    loop_var: __ee_registry_item
     label: "{{ __operation.verb }} the label {{ __ah_configuration_ee_registry__item.name }} to Controller"
     pause: "{{ ah_configuration_ee_registry__loop_delay }}"
   no_log: "{{ ah_configuration_ee_registry_secure_logging }}"
@@ -31,6 +31,7 @@
   register: __ee_registries_job_async
   changed_when: not __ee_registries_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__ee_registry_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: '{{ aap_configuration_async_dir }}'
 
 - name: "Create EE Registry | Wait for finish the ee_registry creation"
@@ -47,5 +48,6 @@
   when: __ee_registries_job_async_result_item.ansible_job_id is defined
   no_log: "{{ ah_configuration_ee_registry_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__ee_registries_job_async_result_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: '{{ aap_configuration_async_dir }}'
 ...

roles/hub_ee_registry_index/tasks/main.yml

@@ -15,7 +15,7 @@
     request_timeout:        "{{ aap_request_timeout | default(omit) }}"
   loop: "{{ ah_ee_registries }}"
   loop_control:
-    loop_var: "__ee_registry_item"
+    loop_var: __ee_registry_item
     label: "{{ __operation.verb }} the label {{ __ah_configuration_ee_registry_index__item.name }} to Controller"
     pause: "{{ ah_configuration_ee_registry_index__loop_delay }}"
   when: __ee_registry_item.index | default(false)
@@ -25,6 +25,7 @@
   register: __ee_registry_indexes_job_async
   changed_when: not __ee_registry_indexes_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__ee_registry_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: '{{ aap_configuration_async_dir }}'
 
 - name: "Index EE Registry | Wait for finish the ee_registry_index creation"
@@ -41,5 +42,6 @@
   when: __ee_registry_indexes_job_async_result_item.ansible_job_id is defined
   no_log: "{{ ah_configuration_ee_registry_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__ee_registry_indexes_job_async_result_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: '{{ aap_configuration_async_dir }}'
 ...

roles/hub_ee_registry_sync/tasks/main.yml

@@ -25,6 +25,7 @@
   register: __ee_registry_syncs_job_async
   changed_when: not __ee_registry_syncs_job_async.changed
   vars:
+    __operation: "{{ operation_translate[__ee_registry_syncs_job_async.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: '{{ aap_configuration_async_dir }}'
 
 - name: "EE Registry Sync | Wait for finish the ee_registry_sync to complete"
@@ -41,5 +42,6 @@
   when: __ee_registry_syncs_job_async_result_item.ansible_job_id is defined
   no_log: "{{ ah_configuration_ee_registry_secure_logging }}"
   vars:
+    __operation: "{{ operation_translate[__ee_registry_syncs_job_async_result_item.state | default(platform_state) | default('present')] }}"
     ansible_async_dir: '{{ aap_configuration_async_dir }}'
 ...