Make organization and notification_type not mandatory to match module documentation in notification_template #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… documentation These are not mandatory if setting state: absent for removal, so do not make them mandatory in this role
djdanielsson
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make organization and notification_type not mandatory to match module documentation in notification_template
These are not mandatory if setting state: absent for removal, so do not make them mandatory in this role
https://docs.ansible.com/ansible/latest/collections/awx/awx/notification_template_module.html
How should this be tested?
Pipeline testing
Is there a relevant Issue open for this?
No
Other Relevant info, PRs, etc
Replacing #1004 for a cleaner commit history