Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix token variable name in to README #1015

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

akira6592
Copy link
Contributor

What does this PR do?

fix controller_oauthtoken to aap_token.

In README.md in each roles and CONVERSION_GUIDE.md, the token variable name is aap_token.

But in only top README.md was still controller_oauthtoken.

How should this be tested?

Is there a relevant Issue open for this?

Other Relevant info, PRs, etc

@akira6592 akira6592 requested a review from a team as a code owner December 17, 2024 12:17
@sean-m-sullivan
Copy link
Collaborator

Thanks for the PR, I was trying to review your latest blog, if you find more issues, please open or alert us. I know the issue with giving non-existent options is a thing, but that is a limitation of the role argument specs, it doesn't handle lists of arguments well.

@sean-m-sullivan sean-m-sullivan merged commit 40453cb into redhat-cop:devel Dec 19, 2024
9 checks passed
@akira6592 akira6592 deleted the fix-token-variable branch December 19, 2024 23:46
@akira6592
Copy link
Contributor Author

Thank you for merging. And thank you for reviewing my blog!

We will continue to check this collection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants