Export differential module new and improved. #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration into devel
sean-m-sullivan
requested review from
Tompage1994,
djdanielsson,
ivarmu and
silvinux
sean-m-sullivan
force-pushed
the
export_diff
branch
from
ff0ac9a to
fc99bab
Compare
sean-m-sullivan
force-pushed
the
export_diff
branch
from
fc99bab to
92fec96
Compare
ivarmu
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
LGTM. Initial testings works really well. Waiting on ansible/awx#13868 to let roles to be more easily compared and treated!
djdanielsson
approved these changes
Apr 28, 2023
…onfiguration into export_diff
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
* update org export * update org export * rebase * add export diff * add export differential module --------- Co-authored-by: David Danielsson <djdanielsson@users.noreply.github.com>
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
* update org export * update org export * rebase * add export diff * add export differential module --------- Co-authored-by: David Danielsson <djdanielsson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR Steals the awx.awx.export module, and parts of the lookup difference module and shoves them together.
It is built to be compatible with either the awx.awx or ansible.controller module.
It only works for the fields that work with the awx cli export, but instead of reducing fields, and comparing direct lists, it does a search and pop on wanted fields and keeps all the fields in place.
It's built to be robust and easy to add to. Though roles may be tricky still.
How should this be tested?
Automated tests included in PR
Is there a relevant Issue open for this?
redhat-cop/aap_configuration_extended#31
In addition when
ansible/awx#13868
Is acted on/improved, we can easily add fields.
Also teams on #468
Is dependent on tooling update to pass sanity tests:
redhat-cop/ansible_collections_tooling#22