Change order of operations #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new/updated key to dict only after removing old ones
sean-m-sullivan
approved these changes
Nov 1, 2023
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
Add new/updated key to dict only after removing old ones Co-authored-by: Marges, RSY (Rick) <rick.marges@achmea.nl> Co-authored-by: Sean Sullivan <ssulliva@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add new/updated key to dict only after removing old ones.
When using plural versions of the
dupitems(for examplejob_templates), onlyteamandroleremain in thecompare_list_reduced.This is due to an error in the order of operations. A singluar version is added to the new dict and then all occurences of
dupitemsare removed. However, the singular version is also in that list.In this PR the order is changed to first removed unwanted keys and only then add the key we want
PS. also solved a unneeded noqa
How should this be tested?
Manual tests:
executerights todummy_templatefor thedummy-team.controller_roles:{"role": "execute", "team": "dummy-team", "job_templates": ["dummy_template"]}present_state: true)Before this PR the
executerole would be removed (even though it's defined in config) from the team.After this, the role is created/saved as expected
Is there a relevant Issue open for this?
Other Relevant info, PRs, etc