Forced bool output to be lowercase #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarmu
requested review from
Tompage1994,
silvinux,
djdanielsson and
sean-m-sullivan
Tompage1994
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Looks good, I'm happy with this.
Could you please just add a changelog fragment as this will affect the actual output and there's a slight chance someone might depend on the value being uppercase.
---
bugfixes:
- Adjusted output of boolean filetree_create fields to provide ansible-lint compatible values.
...
Tompage1994
approved these changes
Mar 25, 2024
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
* forced bool output to be lowercase * Added changelog fragment
przemkalit
pushed a commit
to przemkalit/aap_configuration
that referenced
this pull request
Nov 22, 2024
* forced bool output to be lowercase * Added changelog fragment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Force the output of
boolfilter to be lowercase when templating the output files.Manual and automatic tests.
How should this be tested?
Is there a relevant Issue open for this?
resolves #796
Other Relevant info, PRs, etc
N/A