Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove failing and flakey tests #905

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

jjwatt
Copy link
Contributor

@jjwatt jjwatt commented Sep 13, 2024

What does this PR do?

These tests were failing or flakey when run against an awx devel installation. This PR removes them and makes
ansible-playbook tests/configure_controller.yml
work correctly and run with passes.

How should this be tested?

Change tests/configure_controller.yml and tests/config/controller_auth.yml to match your AWX settings and run:

ansible-playbook tests/configure_controller.yml

Is there a relevant Issue open for this?

No.

Other Relevant info, PRs, etc

NA

These tests were failing or flakey when run against an awx devel
installation. This PR removes them and makes
`ansible-playbook tests/configure_controller.yml`
work correctly and run with passes.
@jjwatt jjwatt requested a review from a team as a code owner September 13, 2024 12:52
Copy link
Collaborator

@Tompage1994 Tompage1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, I'm happy enough for this. Perhaps we need a separate thing to test all the diff stuff as that is inherently flakey anyway,

@jjwatt
Copy link
Contributor Author

jjwatt commented Sep 13, 2024

It seems GHA are failing. These tests were failing locally for me, too, until I put controller auth credentials in both tests/controller_configuration.yml and tests/configs/controller_auth.yml.

@djdanielsson djdanielsson enabled auto-merge (squash) September 26, 2024 13:00
@djdanielsson djdanielsson merged commit 06c5ec9 into redhat-cop:devel Sep 26, 2024
9 of 13 checks passed
przemkalit pushed a commit to przemkalit/aap_configuration that referenced this pull request Nov 22, 2024
These tests were failing or flakey when run against an awx devel
installation. This PR removes them and makes
`ansible-playbook tests/configure_controller.yml`
work correctly and run with passes.

Co-authored-by: Tom Page <tpage@redhat.com>
Co-authored-by: David Danielsson <djdanielsson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants