Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an example credential with HashiCorp Vault source #909

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Added an example credential with HashiCorp Vault source #909

merged 3 commits into from
Sep 19, 2024

Conversation

ryangniadek
Copy link
Contributor

What does this PR do?

Currently, the documentation for the credential_input_sources role does not provide an example for HashiCorp Vault, which requires different metadata fields from the provided CyberArk example.

  • This PR adds an example of using HashiCorp Vault as a credential input source.
  • This PR also adds an example of creating the HashiCorp Vault source credential using the credentials role.

How should this be tested?

This should be tested by comparing the provided example with working config as code implementations that use HashiCorp Vault as a credential input source

Is there a relevant Issue open for this?

No

Other Relevant info, PRs, etc

  • We used roles within this collection with HashiCorp Vault credentials and had a hard time finding documentation. Ideally, all supported credential plugins would be documented and this gets us one step closer.
  • It is debatable whether adding the source credential is in scope for this PR. Those changes are contained in b69ee64 if it's decided to remove them from the PR.

@ryangniadek ryangniadek requested a review from a team as a code owner September 18, 2024 17:36
ivarmu
ivarmu approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@ivarmu ivarmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson merged commit b27aa85 into redhat-cop:devel Sep 19, 2024
10 of 13 checks passed
@ryangniadek ryangniadek deleted the documentation/hashicorp_vault branch September 20, 2024 20:48
przemkalit pushed a commit to przemkalit/aap_configuration that referenced this pull request Nov 22, 2024
@ryangniadek
Added an example credential with HashiCorp Vault source (redhat-cop#909)
6a9cd7f 
* Added an example credential with HashiCorp Vault source

* Added additional information on source_credential and metadata fields

* Added HashiCorp Vault example to credentials README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarmu ivarmu ivarmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryangniadek @ivarmu @djdanielsson