Skip to content

Commit

Permalink
Merge pull request #197 from redhat-cop/dependabot/github_actions/hel…
Browse files Browse the repository at this point in the history
…m/kind-action-1.7.0

Bump helm/kind-action from 1.2.0 to 1.7.0
  • Loading branch information
garethahealy authored May 18, 2023
2 parents 82b0372 + 07d33a3 commit 7f52bfd
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/gatekeeper-k8s-integrationtests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
raw: find policy/* -regex '.*test_data\/integration\/.*$' -exec kubeval --openshift --strict --skip-kinds ServiceMonitor {} \;

- name: Create k8s Kind Cluster
uses: helm/kind-action@v1.2.0
uses: helm/kind-action@v1.7.0

- name: Test against KinD
run: |
Expand Down
9 changes: 6 additions & 3 deletions _test/gatekeeper-k8s-integrationtests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,12 @@ teardown() {

print_info "${status}" "${output}" "${cmd}" "${tmp}"
[ "$status" -eq 1 ]
[[ "${lines[0]}" == *"denied the request: [containerresourcesmemoryunitincorrect] RHCOP-OCP_BESTPRACT-00013: Deployment/invalidresourcesrequestsmemoryunits"* ]]
[[ "${lines[1]}" == *"denied the request: [containerresourcesmemoryunitincorrect] RHCOP-OCP_BESTPRACT-00013: Deployment/invalidresourceslimitsmemoryunits"* ]]
[[ "${#lines[@]}" -eq 2 ]]

[[ "${lines[0]}" == *"spec.template.spec.containers[0].resources.requests[memory]: fractional byte value"* ]]
[[ "${lines[1]}" == *"spec.template.spec.containers[0].resources.limits[memory]: fractional byte value"* ]]
[[ "${lines[2]}" == *"denied the request: [containerresourcesmemoryunitincorrect] RHCOP-OCP_BESTPRACT-00013: Deployment/invalidresourcesrequestsmemoryunits"* ]]
[[ "${lines[3]}" == *"denied the request: [containerresourcesmemoryunitincorrect] RHCOP-OCP_BESTPRACT-00013: Deployment/invalidresourceslimitsmemoryunits"* ]]
[[ "${#lines[@]}" -eq 4 ]]
}

@test "policy/ocp/bestpractices/container-resources-requests-cpuunit-incorrect" {
Expand Down

0 comments on commit 7f52bfd

Please sign in to comment.