-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added azure param spot-excluded-regions #380
Conversation
hey @ScrewTSW is there any chance you can give a try to this new param...and see if it works as you expect? You can use. Parram is And as a tester image you can use the one created from this PR available at:
To test it, if it goes ok I will merge and create a new 0.7.4 mapt version so you can use it as stable on your pipelines |
Tested with:
And checking results, we can confirm excluded regions are not checked anymore:
|
thank you, sorry that I wasn't able to verify it yet. since you've tested it and it functions, I believe it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for your work!
this param will allow to skip certain regions when checking for best spot option. Fix redhat-developer#285 Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected
needs 24c4205
Allow to skip certain regions when checking for best spot option.
Fix #285