Skip retries for Jira errors #290
Merged
+37
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qixiang
force-pushed
the
skip-when-jira-error
branch
from
d2883d1 to
5fffba1
Compare
qixiang
changed the title
qixiang
force-pushed
the
skip-when-jira-error
branch
from
5fffba1 to
0e015f2
Compare
FernandesMF
approved these changes
Jan 20, 2025
Due to the implementation of the allow list and block list, freshmaker is actually checking all advisories with all state changes. When freshmaker lacks permissions to access certain Jira issues, it continuously retries these checks, causing significant performance degradation. This change removes retry attempts for Jira permission errors, as these retries would never succeed. This workaround prevents unnecessary delays in processing advisory state change events.
qixiang
force-pushed
the
skip-when-jira-error
branch
from
0e015f2 to
a97fa97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the implementation of the allow list and block list, freshmaker is actually checking all advisories with all state changes. When freshmaker lacks permissions to access certain Jira issues, it continuously retries these checks, causing significant performance degradation.
This change removes retry attempts for Jira permission errors, as these retries would never succeed. This workaround prevents unnecessary delays in processing advisory state change events.