Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase redisvl test coverage #109

Merged
merged 13 commits into from
Feb 5, 2024
Merged

Conversation

bsbodden
Copy link
Collaborator

@bsbodden bsbodden commented Feb 3, 2024

Upped the coverage to 81% and fix a minor bug in the utils

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (727cd76) 78.92% compared to head (dfad9d3) 80.62%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   78.92%   80.62%   +1.69%     
==========================================
  Files          25       25              
  Lines        1476     1476              
==========================================
+ Hits         1165     1190      +25     
+ Misses        311      286      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tylerhutcherson tylerhutcherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid! I left a few comments. We'll get this merged today.

redisvl/redis/utils.py Show resolved Hide resolved
tests/integration/test_llmcache.py Outdated Show resolved Hide resolved
tests/unit/test_async_search_index.py Show resolved Hide resolved
tests/unit/test_utils.py Outdated Show resolved Hide resolved
@tylerhutcherson tylerhutcherson changed the title Tests and minor fixes Increase redisvl test coverage Feb 5, 2024
@tylerhutcherson tylerhutcherson added the enhancement New feature or request label Feb 5, 2024
@bsbodden bsbodden force-pushed the bsb/tests_and_minor_fixes branch from 29b89d6 to dfad9d3 Compare February 5, 2024 16:03
@tylerhutcherson tylerhutcherson merged commit 8d38801 into main Feb 5, 2024
18 checks passed
@tylerhutcherson tylerhutcherson deleted the bsb/tests_and_minor_fixes branch February 5, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants